Changeset 6631 in josm for trunk/src/org

Timestamp:

2014-01-05T13:22:24+01:00 (10 years ago)

Author:

simon04

Message:

Fix strange effect of UploadDialog where the changeset comment obtained from history was overwritten with an empty value

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/UploadAction.java (modified) (1 diff)
• gui/io/BasicUploadSettingsPanel.java (modified) (1 diff)
• gui/io/UploadDialog.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/UploadAction.java

@@ -236 +236 @@
                     tags.put("source", Main.map.mapView.getLayerInformationForSourceTag());
                 }
+                if (!tags.containsKey("comment")) {
+                    tags.put("comment", dialog.getLastChangesetCommentFromHistory());
+                }
                 dialog.setDefaultChangesetTags(tags);
             }

trunk/src/org/openstreetmap/josm/gui/io/BasicUploadSettingsPanel.java

@@ -142 +142 @@
      */
     public void startUserInput() {
-        List<String> history = hcbUploadComment.getHistory();
-        int age = (int) (System.currentTimeMillis()/1000 - Main.pref.getInteger(HISTORY_LAST_USED_KEY, 0));
-        // only pre-select latest entry if used less than 4 hours ago.
-        if (age < Main.pref.getInteger(HISTORY_MAX_AGE_KEY, 4 * 3600 * 1000) && history != null && !history.isEmpty()) {
-            hcbUploadComment.setText(history.get(0));
-        }
         hcbUploadComment.requestFocusInWindow();
         hcbUploadComment.getEditor().getEditorComponent().requestFocusInWindow();

trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java

@@ -589 +589 @@
         setTitle(tr("Upload to ''{0}''", url));
     }
+
+    public String getLastChangesetCommentFromHistory() {
+        Collection<String> history = Main.pref.getCollection(BasicUploadSettingsPanel.HISTORY_KEY, new ArrayList<String>());
+        int age = (int) (System.currentTimeMillis() / 1000 - Main.pref.getInteger(BasicUploadSettingsPanel.HISTORY_LAST_USED_KEY, 0));
+        if (age < Main.pref.getInteger(BasicUploadSettingsPanel.HISTORY_MAX_AGE_KEY, 4 * 3600 * 1000) && history != null && !history.isEmpty()) {
+            return history.iterator().next();
+        } else {
+            return null;
+        }
+    }
 }