Changeset 6302 in josm for trunk/src/org

Timestamp:

2013-10-06T19:14:04+02:00 (11 years ago)

Author:

Don-vip

Message:

see #7465 - Raise an error when a plugin replaces a way with a zero-node way (such as reverter before v30000)

File:

• trunk/src/org/openstreetmap/josm/command/ChangeCommand.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/command/ChangeCommand.java

@@ -11 +11 @@
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.data.osm.OsmPrimitiveType;
+import org.openstreetmap.josm.data.osm.Way;
 import org.openstreetmap.josm.gui.DefaultNameFormatter;
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
+import org.openstreetmap.josm.tools.CheckParameterUtil;
 import org.openstreetmap.josm.tools.ImageProvider;
 
@@ -26 +28 @@
     private final OsmPrimitive newOsm;
 
-
     public ChangeCommand(OsmPrimitive osm, OsmPrimitive newOsm) {
         super();
         this.osm = osm;
         this.newOsm = newOsm;
+        sanityChecks();
     }
 
@@ -37 +39 @@
         this.osm = osm;
         this.newOsm = newOsm;
+        sanityChecks();
+    }
+    
+    private void sanityChecks() {
+        CheckParameterUtil.ensureParameterNotNull(osm, "osm");
+        CheckParameterUtil.ensureParameterNotNull(newOsm, "newOsm");
+        if (newOsm instanceof Way) {
+            // Do not allow to create empty ways (see #7465)
+            if (((Way)newOsm).getNodesCount() == 0) {
+                throw new IllegalArgumentException(tr("New way {0} has 0 nodes", newOsm));
+            }
+        }
     }