Changeset 5767 in josm for trunk/src/org

Timestamp:

2013-03-09T09:45:55+01:00 (12 years ago)

Author:

Don-vip

Message:

fix #8495 - fix FixDataHook$FixDataSpace.fixKeys algo

File:

• trunk/src/org/openstreetmap/josm/actions/upload/FixDataHook.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/actions/upload/FixDataHook.java

@@ -6 +6 @@
 import java.util.Collection;
 import java.util.Collections;
+import java.util.HashMap;
 import java.util.LinkedList;
 import java.util.List;
-import java.util.HashMap;
 import java.util.Map;
 import java.util.Map.Entry;
@@ -73 +73 @@
         @Override
         public boolean fixKeys(Map<String, String> keys, OsmPrimitive osm) {
-            boolean changed = false;
-            for(Entry<String, String> e : keys.entrySet()) {
+            Map<String, String> newKeys = new HashMap<String, String>(keys);
+            for (Entry<String, String> e : keys.entrySet()) {
                 String v = e.getValue().trim();
                 String k = e.getKey().trim();
                 if(!e.getKey().equals(k)) {
-                    changed = true;
                     boolean drop = k.isEmpty() || v.isEmpty();
                     if(drop || !keys.containsKey(k)) {
-                        keys.remove(e.getKey());
+                        newKeys.remove(e.getKey());
                         if(!drop)
-                            keys.put(k, v);
+                            newKeys.put(k, v);
                     }
                 } else if(!e.getValue().equals(v)) {
                     if(v.isEmpty())
-                        keys.remove(k);
+                        newKeys.remove(k);
                     else
-                        keys.put(k, v);
-                    changed = true;
+                        newKeys.put(k, v);
                 }
+            }
+            boolean changed = !keys.equals(newKeys);
+            if (changed) {
+                keys.clear();
+                keys.putAll(newKeys);
             }
             return changed;
@@ -180 +183 @@
         Collection<Command> cmds = new LinkedList<Command>();
 
-        boolean needsChange = false;
         for (OsmPrimitive osm : objectsToUpload) {
             Map<String, String> keys = osm.getKeys();