Changeset 5747 in josm for trunk/src/org/openstreetmap

Timestamp:

2013-02-27T08:53:22+01:00 (12 years ago)

Author:

akks

Message:

Extrude mode: not add way modification command when it is not needed (rectangles etc.)
noticed by OverQuantum

File:

• trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java

@@ -432 +432 @@
         Collection<Command> cmds = new LinkedList<Command>();
         Way wnew = new Way(selectedSegment.way);
+        boolean wayWasModified = false;
         int insertionPoint = selectedSegment.lowerIndex + 1;
 
@@ -447 +448 @@
             Node n1New = new Node(Main.getProjection().eastNorth2latlon(newN1en));
             wnew.addNode(insertionPoint, n1New);
+            wayWasModified = true;
             insertionPoint ++;
             cmds.add(new AddCommand(n1New));
@@ -464 +466 @@
             Node n2New = new Node(Main.getProjection().eastNorth2latlon(newN2en));
             wnew.addNode(insertionPoint, n2New);
+            wayWasModified = true;
             insertionPoint ++;
             cmds.add(new AddCommand(n2New));
@@ -471 +474 @@
         if (wnew.getNodesCount() == 4) {
             wnew.addNode(selectedSegment.getFirstNode());
-        }
-
-        cmds.add(new ChangeCommand(selectedSegment.way, wnew));
+            wayWasModified = true;
+        }
+        if (wayWasModified) {
+            // we only need to change the way if its node list was really modified
+            cmds.add(new ChangeCommand(selectedSegment.way, wnew));
+        }
         Command c = new SequenceCommand(tr("Extrude Way"), cmds);
         Main.main.undoRedo.add(c);