Changeset 5675 in josm for trunk

Timestamp:

2013-01-27T14:36:50+01:00 (11 years ago)

Author:

Don-vip

Message:

fix #8382 - CCE in TaggingPreset

File:

• trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java

@@ -513 +513 @@
         }
 
+        private static String getValue(Component comp) {
+            if (comp instanceof JosmComboBox) {
+                return ((JosmComboBox) comp).getEditor().getItem().toString();
+            } else if (comp instanceof JTextField) {
+                return ((JTextField) comp).getText();
+            } else if (comp instanceof JPanel) {
+                return getValue(((JPanel)comp).getComponent(0));
+            } else {
+                return null;
+            }
+        }
+        
         @Override
         public void addCommands(List<Tag> changedTags) {
 
             // return if unchanged
-            String v = null;
-            if (value instanceof JosmComboBox) {
-                v = ((JosmComboBox) value).getEditor().getItem().toString();
-            } else if (value instanceof JTextField) {
-                v = ((JTextField) value).getText();
-            } else if (value instanceof JPanel) {
-                // this is what was alluded to with "ugly fashion" above.
-                v = ((JTextField) (((JPanel)value).getComponent(0))).getText();
-            } else {
+            String v = getValue(value);
+            if (v == null) {
                 System.err.println("No 'last value' support for component " + value);
                 return;
             }
-               
+            
             v = v.trim();