Changeset 5519 in josm

Timestamp:

2012-09-30T17:36:39+02:00 (13 years ago)

Author:

Don-vip

Message:

fix #8090 - Removing saved non-uploadable layer asks for confirmation

Location:

trunk/src/org/openstreetmap/josm

Files:

• Main.java (modified) (1 diff)
• gui/MapView.java (modified) (5 diffs)
• gui/dialogs/LayerListDialog.java (modified) (2 diffs)
• gui/layer/OsmDataLayer.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/Main.java

@@ -628 +628 @@
     }
 
+    /**
+     * Asks user to perform "save layer" operations (save .osm on disk and/or upload osm data to server) for all {@link OsmDataLayer} before JOSM exits.
+     * @return {@code true} if there was nothing to save, or if the user wants to proceed to save operations. {@code false} if the user cancels.
+     * @since 2025
+     */
     public static boolean saveUnsavedModifications() {
-        if (map == null) return true;
-        SaveLayersDialog dialog = new SaveLayersDialog(Main.parent);
+        if (map == null || map.mapView == null) return true;
+        return saveUnsavedModifications(map.mapView.getLayersOfType(OsmDataLayer.class), true);
+    }
+
+    /**
+     * Asks user to perform "save layer" operations (save .osm on disk and/or upload osm data to server) before osm layers deletion.
+     * 
+     * @param selectedLayers The layers to check. Only instances of {@link OsmDataLayer} are considered.
+     * @param exit {@code true} if JOSM is exiting, {@code false} otherwise.
+     * @return {@code true} if there was nothing to save, or if the user wants to proceed to save operations. {@code false} if the user cancels.
+     * @since 5519
+     */
+    public static boolean saveUnsavedModifications(List<? extends Layer> selectedLayers, boolean exit) {
+        SaveLayersDialog dialog = new SaveLayersDialog(parent);
         List<OsmDataLayer> layersWithUnmodifiedChanges = new ArrayList<OsmDataLayer>();
-        for (OsmDataLayer l: Main.map.mapView.getLayersOfType(OsmDataLayer.class)) {
-            if ((l.requiresSaveToFile() || l.requiresUploadToServer()) && l.data.isModified()) {
-                layersWithUnmodifiedChanges.add(l);
-            }
-        }
-        dialog.prepareForSavingAndUpdatingLayersBeforeExit();
+        for (Layer l: selectedLayers) {
+            if (!(l instanceof OsmDataLayer)) {
+                continue;
+            }
+            OsmDataLayer odl = (OsmDataLayer)l;
+            if ((odl.requiresSaveToFile() || (odl.requiresUploadToServer() && !odl.isUploadDiscouraged())) && odl.data.isModified()) {
+                layersWithUnmodifiedChanges.add(odl);
+            }
+        }
+        if (exit) {
+            dialog.prepareForSavingAndUpdatingLayersBeforeExit();
+        } else {
+            dialog.prepareForSavingAndUpdatingLayersBeforeDelete();
+        }
         if (!layersWithUnmodifiedChanges.isEmpty()) {
             dialog.getModel().populate(layersWithUnmodifiedChanges);

trunk/src/org/openstreetmap/josm/gui/MapView.java

@@ -69 +69 @@
  * @author imi
  */
-public class MapView extends NavigatableComponent implements PropertyChangeListener, PreferenceChangedListener {
+public class MapView extends NavigatableComponent implements PropertyChangeListener, PreferenceChangedListener, OsmDataLayer.LayerStateChangeListener {
 
     /**
@@ -312 +312 @@
         }
         fireLayerAdded(layer);
-        boolean callSetActiveLayer = layer instanceof OsmDataLayer || activeLayer == null;
+        boolean isOsmDataLayer = layer instanceof OsmDataLayer;
+        if (isOsmDataLayer) {
+            ((OsmDataLayer)layer).addLayerStateChangeListener(this);
+        }
+        boolean callSetActiveLayer = isOsmDataLayer || activeLayer == null;
         if (callSetActiveLayer) {
             // autoselect the new layer
@@ -393 +397 @@
         if (layer == activeLayer) {
             setActiveLayer(determineNextActiveLayer(layersList), false);
+        }
+        
+        if (layer instanceof OsmDataLayer) {
+            ((OsmDataLayer)layer).removeLayerPropertyChangeListener(this);
         }
 
@@ -863 +871 @@
 
     protected void refreshTitle() {
-        boolean dirty = editLayer != null && (editLayer.requiresSaveToFile() || editLayer.requiresUploadToServer());
+        boolean dirty = editLayer != null && (editLayer.requiresSaveToFile() || (editLayer.requiresUploadToServer() && !editLayer.isUploadDiscouraged()));
         if (dirty) {
             JOptionPane.getFrameForComponent(Main.parent).setTitle("* " + tr("Java OpenStreetMap Editor"));
@@ -893 +901 @@
     }
 
+    @Override
+    public void uploadDiscouragedChanged(OsmDataLayer layer, boolean newValue) {
+        if (layer == getEditLayer()) {
+            refreshTitle();
+        }
+    }
 }

trunk/src/org/openstreetmap/josm/gui/dialogs/LayerListDialog.java

@@ -389 +389 @@
         }
 
-        protected boolean enforceUploadOrSaveModifiedData(List<Layer> selectedLayers) {
-            SaveLayersDialog dialog = new SaveLayersDialog(Main.parent);
-            List<OsmDataLayer> layersWithUnmodifiedChanges = new ArrayList<OsmDataLayer>();
-            for (Layer l: selectedLayers) {
-                if (! (l instanceof OsmDataLayer)) {
-                    continue;
-                }
-                OsmDataLayer odl = (OsmDataLayer)l;
-                if ((odl.requiresSaveToFile() || odl.requiresUploadToServer()) && odl.data.isModified()) {
-                    layersWithUnmodifiedChanges.add(odl);
-                }
-            }
-            dialog.prepareForSavingAndUpdatingLayersBeforeDelete();
-            if (!layersWithUnmodifiedChanges.isEmpty()) {
-                dialog.getModel().populate(layersWithUnmodifiedChanges);
-                dialog.setVisible(true);
-                switch(dialog.getUserAction()) {
-                case CANCEL: return false;
-                case PROCEED: return true;
-                default: return false;
-                }
-            }
-            return true;
-        }
-
         @Override
         public void actionPerformed(ActionEvent e) {
@@ -419 +394 @@
             if (selectedLayers.isEmpty())
                 return;
-            if (! enforceUploadOrSaveModifiedData(selectedLayers))
+            if (!Main.saveUnsavedModifications(selectedLayers, false))
                 return;
-            for(Layer l: selectedLayers) {
+            for (Layer l: selectedLayers) {
                 Main.main.removeLayer(l);
             }

trunk/src/org/openstreetmap/josm/gui/layer/OsmDataLayer.java

@@ -28 +28 @@
 import java.util.List;
 import java.util.Map;
+import java.util.concurrent.CopyOnWriteArrayList;
 
 import javax.swing.AbstractAction;
@@ -165 +166 @@
         void commandChanged(int queueSize, int redoSize);
     }
+    
+    /**
+     * Listener called when a state of this layer has changed.
+     */
+    public interface LayerStateChangeListener {
+        /**
+         * Notifies that the "upload discouraged" (upload=no) state has changed.
+         * @param layer The layer that has been modified
+         * @param newValue The new value of the state
+         */
+        void uploadDiscouragedChanged(OsmDataLayer layer, boolean newValue);
+    }
+    
+    private final CopyOnWriteArrayList<LayerStateChangeListener> layerStateChangeListeners = new CopyOnWriteArrayList<LayerStateChangeListener>();
+    
+    /**
+     * Adds a layer state change listener
+     *
+     * @param listener the listener. Ignored if null or already registered.
+     * @since 5519
+     */
+    public void addLayerStateChangeListener(LayerStateChangeListener listener) {
+        if (listener != null) {
+            layerStateChangeListeners.addIfAbsent(listener);
+        }
+    }
+    
+    /**
+     * Removes a layer property change listener
+     *
+     * @param listener the listener. Ignored if null or already registered.
+     * @since 5519
+     */
+    public void removeLayerPropertyChangeListener(LayerStateChangeListener listener) {
+        layerStateChangeListeners.remove(listener);
+    }
 
     /**
@@ -742 +779 @@
 
     public final void setUploadDiscouraged(boolean uploadDiscouraged) {
-        data.setUploadDiscouraged(uploadDiscouraged);
+        if (uploadDiscouraged ^ isUploadDiscouraged()) {
+            data.setUploadDiscouraged(uploadDiscouraged);
+            for (LayerStateChangeListener l : layerStateChangeListeners) {
+                l.uploadDiscouragedChanged(this, uploadDiscouraged);
+            }
+        }
     }