Changeset 5439 in josm

Timestamp:

2012-08-13T01:18:23+02:00 (12 years ago)

Author:

Don-vip

Message:

Adapt OAuth user identification mechanism so it is no longer reserved to changeset dialog and that it is only asked again when necessary

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• JosmUserIdentityManager.java (modified) (5 diffs)
• dialogs/changeset/ChangesetCacheManager.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/JosmUserIdentityManager.java

@@ -59 +59 @@
         if (instance == null) {
             instance = new JosmUserIdentityManager();
-            instance.initFromPreferences();
+            if (Main.pref.get("osm-server.auth-method").equals("oauth")) {
+                try {
+                    instance.initFromOAuth(Main.parent);
+                } catch (Throwable t) {
+                    t.printStackTrace();
+                    // Fall back to preferences if OAuth identification fails for any reason
+                    instance.initFromPreferences();
+                }
+            } else {
+                instance.initFromPreferences();
+            }
             Main.pref.addPreferenceChangeListener(instance);
         }
@@ -67 +77 @@
     private String userName;
     private UserInfo userInfo;
+    private boolean accessTokenKeyChanged;
+    private boolean accessTokenSecretChanged;
 
     private JosmUserIdentityManager() {
@@ -183 +195 @@
             }
         } else {
-            if (!userName.equals(this.userName)) {
+            if (userName != null && !userName.equals(this.userName)) {
                 setPartiallyIdentified(userName);
             } else {
@@ -238 +250 @@
             }
             return;
-        }
-
-        if (evt.getKey().equals("osm-server.url")) {
+            
+        } else if (evt.getKey().equals("osm-server.url")) {
             if (!(evt.getNewValue() instanceof StringSetting)) return;
             String newValue = ((StringSetting) evt.getNewValue()).getValue();
@@ -248 +259 @@
                 setPartiallyIdentified(getUserName());
             }
+            
+        } else if (evt.getKey().equals("oauth.access-token.key")) {
+            accessTokenKeyChanged = true;
+            
+        } else if (evt.getKey().equals("oauth.access-token.secret")) {
+            accessTokenSecretChanged = true;
+        }
+        
+        if (accessTokenKeyChanged && accessTokenSecretChanged) {
+            accessTokenKeyChanged = false;
+            accessTokenSecretChanged = false;
+            if (Main.pref.get("osm-server.auth-method").equals("oauth")) {
+                try {
+                    instance.initFromOAuth(Main.parent);
+                } catch (Throwable t) {
+                    t.printStackTrace();
+                }
+            }
         }
     }

trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetCacheManager.java

@@ -532 +532 @@
         public void actionPerformed(ActionEvent arg0) {
             JosmUserIdentityManager im = JosmUserIdentityManager.getInstance();
-            if (Main.pref.get("osm-server.auth-method").equals("oauth")) {
-                im.initFromOAuth(ChangesetCacheManager.this);
-            } else {
-                im.initFromPreferences();
-                if (im.isAnonymous()) {
-                    alertAnonymousUser();
-                    return;
-                }
+            if (im.isAnonymous()) {
+                alertAnonymousUser();
+                return;
             }
             ChangesetQuery query = new ChangesetQuery();