Changeset 5108 in josm for trunk/src/org/openstreetmap

Timestamp:

2012-03-20T11:27:08+01:00 (12 years ago)

Author:

xeen

Message:

remove superfluous calls to recalculateBounds() and add clarifying comment.

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/downloadtasks/DownloadGpsTask.java (modified) (1 diff)
• data/gpx/GpxData.java (modified) (1 diff)
• io/NmeaReader.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/downloadtasks/DownloadGpsTask.java

@@ -103 +103 @@
             if (rawData == null)
                 return;
-            rawData.recalculateBounds();
             String name = tr("Downloaded GPX Data");
             GpxLayer layer = new GpxLayer(rawData, name);

trunk/src/org/openstreetmap/josm/data/gpx/GpxData.java

@@ -83 +83 @@
     }
 
-    // FIXME might perhaps use visitor pattern?
+    /**
+     * calculates the bounding box of available data and returns it.
+     * The bounds are not stored internally, but recalculated every time
+     * this function is called.
+     * 
+     * FIXME might perhaps use visitor pattern?
+     */
     public Bounds recalculateBounds() {
         Bounds bounds = null;

trunk/src/org/openstreetmap/josm/io/NmeaReader.java

@@ -209 +209 @@
             currentTrack.add(ps.waypoints);
             data.tracks.add(new ImmutableGpxTrack(currentTrack, Collections.<String, Object>emptyMap()));
-            data.recalculateBounds();
 
         } catch (final IOException e) {