Changeset 5100 in josm for trunk

Timestamp:

2012-03-18T12:59:28+01:00 (12 years ago)

Author:

xeen

Message:

fix highlights still being drawn in draw mode when cursor exited the map view

File:

• trunk/src/org/openstreetmap/josm/actions/mapmode/DrawAction.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/actions/mapmode/DrawAction.java

@@ -137 +137 @@
      * Checks if a map redraw is required and does so if needed. Also updates the status bar
      */
-    private void redrawIfRequired() {
+    private boolean redrawIfRequired() {
         updateStatusLine();
         // repaint required if the helper line is active.
@@ -157 +157 @@
 
         if ((!drawHelperLine || wayIsFinished) && !drawTargetHighlight)
-            return;
+            return false;
 
         // update selection to reflect which way being modified
@@ -177 +177 @@
             Main.map.mapView.repaint();
         }
+        return needsRepaint;
     }
 
@@ -864 +865 @@
         mousePos = e.getPoint();
         snapHelper.noSnapNow();
-        Main.map.mapView.repaint();
+        boolean repaintIssued = removeHighlighting();
+        // force repaint in case snapHelper needs one. If removeHighlighting
+        // caused one already, don’t do it again.
+        if(!repaintIssued) {
+            Main.map.mapView.repaint();
+        }
     }
 
@@ -1040 +1046 @@
     /**
      * Removes target highlighting from primitives. Issues repaint if required.
+     * Returns true if a repaint has been issued.
      */
-    private void removeHighlighting() {
+    private boolean removeHighlighting() {
         newHighlights = new HashSet<OsmPrimitive>();
-        redrawIfRequired();
+        return redrawIfRequired();
     }