Changeset 5079 in josm for trunk

Timestamp:

2012-03-14T12:16:08+01:00 (13 years ago)

Author:

simon04

Message:

make toolbar popup menu more intuitive (also show popup menu on empty space)

File:

• trunk/src/org/openstreetmap/josm/gui/preferences/ToolbarPreferences.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/preferences/ToolbarPreferences.java

@@ -369 +369 @@
     private static class ToolbarPopupMenu extends JPopupMenu {
         public ToolbarPopupMenu(final ActionDefinition action) {
-            
-            add(tr("Remove from toolbar",action.getDisplayName()))
-                    .addActionListener(new ActionListener() {
-                        public void actionPerformed(ActionEvent e) {
-                            Collection<String> t = new LinkedList<String>(getToolString());
-                            ActionParser parser = new ActionParser(null);
-                            // get text definition of current action
-                            String res = parser.saveAction(action);
-                            // remove the button from toolbar preferences
-                            t.remove( res );
-                            Main.pref.putCollection("toolbar", t);
-                            Main.toolbar.refreshToolbarControl();                
-                        }
-            });
+
+            if(action != null) {
+                add(tr("Remove from toolbar",action.getDisplayName()))
+                        .addActionListener(new ActionListener() {
+                            public void actionPerformed(ActionEvent e) {
+                                Collection<String> t = new LinkedList<String>(getToolString());
+                                ActionParser parser = new ActionParser(null);
+                                // get text definition of current action
+                                String res = parser.saveAction(action);
+                                // remove the button from toolbar preferences
+                                t.remove( res );
+                                Main.pref.putCollection("toolbar", t);
+                                Main.toolbar.refreshToolbarControl();
+                            }
+                });
+            }
             
             add(tr("Configure toolbar")).addActionListener(new ActionListener() {
@@ -801 +803 @@
     public ToolbarPreferences() {
         control.setFloatable(false);
+        control.addMouseListener(new PopupMenuLauncher(new ToolbarPopupMenu(null)));
     }