Changeset 4567 in josm

Timestamp:

2011-11-02T15:44:20+01:00 (13 years ago)

Author:

stoecker

Message:

fix #6875 - patch by Larry0ua - Data Layer can be changed after selecting another layer

Location:

trunk

Files:

• data/cs.lang (modified) ( previous)
• data/el.lang (modified) ( previous)
• data/es.lang (modified) ( previous)
• data/et.lang (modified) ( previous)
• data/fr.lang (modified) ( previous)
• data/is.lang (modified) ( previous)
• data/it.lang (modified) ( previous)
• data/uk.lang (modified) ( previous)
• data/zh_CN.lang (modified) ( previous)
• data/zh_TW.lang (modified) ( previous)
• src/org/openstreetmap/josm/Main.java (modified) (1 diff)
• src/org/openstreetmap/josm/gui/MapFrame.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/Main.java

@@ -278 +278 @@
             final MapFrame mapFrame = new MapFrame(contentPanePrivate);
             setMapFrame(mapFrame);
-            mapFrame.selectMapMode((MapMode)mapFrame.getDefaultButtonAction());
+            mapFrame.selectMapMode((MapMode)mapFrame.getDefaultButtonAction(), layer);
             mapFrame.setVisible(true);
             mapFrame.initializeDialogsPane();

trunk/src/org/openstreetmap/josm/gui/MapFrame.java

@@ -288 +288 @@
         return button;
     }
-    
+
     public void validateToolBarToggle() {
         toolBarToggle.removeAll();
@@ -320 +320 @@
     /**
      * Change the operating map mode for the view. Will call unregister on the
-     * old MapMode and register on the new one.
+     * old MapMode and register on the new one. Now this function also verifies
+     * if new map mode is correct mode for current layer and does not change mode
+     * in such cases.
      * @param mapMode   The new mode to set.
      */
     public void selectMapMode(MapMode newMapMode) {
+        selectMapMode(newMapMode, mapView.getActiveLayer());
+    }
+
+    /**
+     * Another version of the selectMapMode for changing layer action.
+     * Pass newly selected layer to this method.
+     * @param newMapMode
+     * @param newLayer
+     */
+    public void selectMapMode(MapMode newMapMode, Layer newLayer) {
+        if (newMapMode == null || !newMapMode.layerIsSupported(newLayer))
+            return;
+
         MapMode oldMapMode = this.mapMode;
         if (newMapMode == oldMapMode)
@@ -332 +347 @@
         this.mapMode = newMapMode;
         newMapMode.enterMode();
-        lastMapMode.put(mapView.getActiveLayer(), newMapMode);
+        lastMapMode.put(newLayer, newMapMode);
         fireMapModeChanged(oldMapMode, newMapMode);
     }
@@ -474 +489 @@
             modeChanged = newMapMode != mapMode;
             if (newMapMode != null) {
-                selectMapMode(newMapMode);
-            } // it would be nice to select first supported mode when layer is first selected, but it don't work well with for example editgpx layer
+                selectMapMode(newMapMode, newLayer); // it would be nice to select first supported mode when layer is first selected, but it don't work well with for example editgpx layer
+            } else {
+                mapMode.exitMode(); // if new mode is null - simply exit from previous mode
+            }
         }
         if (!modeChanged && mapMode != null) {