Changeset 4393 in josm for trunk/src/org/openstreetmap

Timestamp:

2011-09-01T11:00:02+02:00 (13 years ago)

Author:

simon04

Message:

fix #5471 - information dialog when opening an empty osm file

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/OpenFileAction.java (modified) (1 diff)
• io/OsmImporter.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/OpenFileAction.java

@@ -284 +284 @@
             if (importer.isBatchImporter()) {
                 if (canceled) return;
-                String msg;
-                if (files.size() == 1) {
-                    msg = tr("Opening 1 file...");
-                } else {
-                    msg = trn("Opening {0} file...", "Opening {0} files...", files.size(), files.size());
-                }
+                String msg = trn("Opening {0} file...", "Opening {0} files...", files.size(), files.size());
                 getProgressMonitor().setCustomText(msg);
                 getProgressMonitor().indeterminateSubTask(msg);

trunk/src/org/openstreetmap/josm/io/OsmImporter.java

@@ -10 +10 @@
 import java.io.InputStream;
 
+import javax.swing.JOptionPane;
 import javax.swing.SwingUtilities;
 
@@ -39 +40 @@
     }
 
-    protected void importData(InputStream in, File associatedFile) throws IllegalDataException {
-        DataSet dataSet = OsmReader.parseDataSet(in, NullProgressMonitor.INSTANCE);
+    protected void importData(InputStream in, final File associatedFile) throws IllegalDataException {
+        final DataSet dataSet = OsmReader.parseDataSet(in, NullProgressMonitor.INSTANCE);
         final OsmDataLayer layer = new OsmDataLayer(dataSet, associatedFile.getName(), associatedFile);
         // FIXME: remove UI stuff from IO subsystem
         //
         Runnable uiStuff = new Runnable() {
+            @Override
             public void run() {
+                if (dataSet.allPrimitives().isEmpty()) {
+                    JOptionPane.showMessageDialog(
+                            Main.parent,
+                            tr("No data found in file {0}.", associatedFile.getPath()),
+                            tr("Open OSM file"),
+                            JOptionPane.INFORMATION_MESSAGE);
+                }
                 Main.main.addLayer(layer);
                 layer.onPostLoadFromFile();