Changeset 4263 in josm for trunk/src/org

Timestamp:

2011-07-25T00:48:51+02:00 (13 years ago)

Author:

bastiK

Message:

do not save username in preference file unconditionally - let the credentials manager handle it

Location:

trunk/src/org/openstreetmap/josm

Files:

• gui/JosmUserIdentityManager.java (modified) (2 diffs)
• gui/history/VersionInfoPanel.java (modified) (2 diffs)
• gui/preferences/server/BasicAuthenticationPreferencesPanel.java (modified) (1 diff)
• io/GpxExporter.java (modified) (3 diffs)
• io/auth/CredentialsManager.java (modified) (3 diffs)
• tools/ExceptionUtil.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/JosmUserIdentityManager.java

@@ -10 +10 @@
 import org.openstreetmap.josm.data.Preferences.PreferenceChangedListener;
 import org.openstreetmap.josm.data.osm.UserInfo;
+import org.openstreetmap.josm.io.auth.CredentialsManager;
 import org.openstreetmap.josm.tools.CheckParameterUtil;
 
@@ -168 +169 @@
      */
     public void initFromPreferences() {
-        String userName = Main.pref.get("osm-server.username");
+        String userName = CredentialsManager.getInstance().getUsername();
         if (isAnonymous()) {
             if (userName != null && ! userName.trim().equals("")) {

trunk/src/org/openstreetmap/josm/gui/history/VersionInfoPanel.java

@@ -22 +22 @@
 import org.openstreetmap.josm.gui.JMultilineLabel;
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
+import org.openstreetmap.josm.io.auth.CredentialsManager;
 import org.openstreetmap.josm.tools.CheckParameterUtil;
 import org.openstreetmap.josm.tools.UrlLabel;
@@ -147 +148 @@
             lblUser.setDescription(username);
         } else {
-            String user = Main.pref.get("osm-server.username");
+            String user = CredentialsManager.getInstance().getUsername();
             if (user == null) {
                 lblUser.setDescription(tr("anonymous"));

trunk/src/org/openstreetmap/josm/gui/preferences/server/BasicAuthenticationPreferencesPanel.java

@@ -119 +119 @@
             );
             cm.store(RequestorType.SERVER, pa);
-            // always save the username to the preferences if it isn't already saved there
-            // by the credential manager
-            if (! (cm instanceof JosmPreferencesCredentialAgent)) {
-                Main.pref.put("osm-server.username", tfOsmUserName.getText().trim());
-            }
         } catch(CredentialsAgentException e) {
             e.printStackTrace();

trunk/src/org/openstreetmap/josm/io/GpxExporter.java

@@ -34 +34 @@
 import org.openstreetmap.josm.gui.layer.Layer;
 import org.openstreetmap.josm.gui.layer.OsmDataLayer;
+import org.openstreetmap.josm.io.auth.CredentialsManager;
 import org.openstreetmap.josm.tools.CheckParameterUtil;
 import org.openstreetmap.josm.tools.GBC;
@@ -84 +85 @@
         JLabel emailLabel = new JLabel(tr("E-Mail"));
         p.add(emailLabel, GBC.std().insets(10, 0, 5, 0));
-        JTextField email = new JTextField(Main.pref.get("osm-server.username"));
+        String user = CredentialsManager.getInstance().getUsername();
+        JTextField email = new JTextField(user == null ? "" : user);
         p.add(email, GBC.eol().fill(GBC.HORIZONTAL));
         JLabel copyrightLabel = new JLabel(tr("Copyright (URL)"));
@@ -232 +234 @@
                 emailLabel.setEnabled(b);
                 authorName.setText(b ? Main.pref.get("lastAuthorName") : "");
-                email.setText(b ? Main.pref.get("osm-server.username") : "");
+                String user = CredentialsManager.getInstance().getUsername();
+                email.setText(b ? (user == null ? "" : user) : "");
 
                 boolean authorSet = authorName.getText().length() != 0;

trunk/src/org/openstreetmap/josm/io/auth/CredentialsManager.java

@@ -7 +7 @@
 
 import org.openstreetmap.josm.data.oauth.OAuthToken;
+import org.openstreetmap.josm.gui.JosmUserIdentityManager;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -63 +65 @@
     }
 
+    public String getUsername() {
+        String username = null;
+        try {
+            PasswordAuthentication auth = lookup(RequestorType.SERVER);
+            if (auth != null) {
+                username = auth.getUserName();
+            }
+        } catch (CredentialsAgentException ex) {
+            return null;
+        }
+        if (username == null) return null;
+        username = username.trim();
+        return Utils.equal(username, "") ? null : username;
+    }
+
     @Override
     public PasswordAuthentication lookup(RequestorType requestorType) throws CredentialsAgentException {
@@ -70 +87 @@
     @Override
     public void store(RequestorType requestorType, PasswordAuthentication credentials) throws CredentialsAgentException {
+        if (requestorType == RequestorType.SERVER && credentials.getUserName() != null) {
+            JosmUserIdentityManager.getInstance().setPartiallyIdentified(credentials.getUserName());
+        }
         delegate.store(requestorType, credentials);
     }

trunk/src/org/openstreetmap/josm/tools/ExceptionUtil.java

@@ -27 +27 @@
 import org.openstreetmap.josm.io.OsmApiInitializationException;
 import org.openstreetmap.josm.io.OsmTransferException;
+import org.openstreetmap.josm.io.auth.CredentialsManager;
 
 public class ExceptionUtil {
@@ -115 +116 @@
                 + "Please check the username and the password in the JOSM preferences."
                 + "</html>",
-                Main.pref.get("osm-server.username")
+                CredentialsManager.getInstance().getUsername()
         );
     }