Changeset 4172 in josm for trunk/src

Timestamp:

2011-06-26T13:43:35+02:00 (13 years ago)

Author:

stoecker

Message:

remove unused icons, make connection timouts configurable and increase them a bit to handle JOSM server delays

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/AddImageryLayerAction.java (modified) (1 diff)
• data/osm/OsmPrimitiveType.java (modified) (1 diff)
• data/validation/Severity.java (modified) (1 diff)
• gui/ImageryMenu.java (modified) (1 diff)
• gui/dialogs/properties/PropertiesDialog.java (modified) (2 diffs)
• gui/download/PlaceSelection.java (modified) (1 diff)
• gui/layer/markerlayer/Marker.java (modified) (1 diff)
• gui/mappaint/MapPaintStyles.java (modified) (1 diff)
• gui/tagging/TaggingPreset.java (modified) (1 diff)
• io/MirroredInputStream.java (modified) (2 diffs)
• io/OsmApi.java (modified) (1 diff)
• io/OsmServerReader.java (modified) (1 diff)
• io/imagery/WMSGrabber.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/AddImageryLayerAction.java

@@ -16 +16 @@
 
     public AddImageryLayerAction(ImageryInfo info) {
-        super(info.getMenuName(), "imagery_menu", tr("Add imagery layer {0}",info.getName()), null, false, false);
+        super(info.getMenuName(), /* ICON */"imagery_menu", tr("Add imagery layer {0}",info.getName()), null, false, false);
         putValue("toolbar", "imagery_" + info.getToolbarName());
         this.info = info;

trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitiveType.java

@@ -8 +8 @@
 public enum OsmPrimitiveType {
 
-    NODE (marktr("node"), Node.class, NodeData.class),
-    WAY  (marktr("way"), Way.class, WayData.class),
-    RELATION (marktr("relation"), Relation.class, RelationData.class),
+    NODE (marktr(/* ICON(data/) */"node"), Node.class, NodeData.class),
+    WAY  (marktr(/* ICON(data/) */"way"), Way.class, WayData.class),
+    RELATION (marktr(/* ICON(data/) */"relation"), Relation.class, RelationData.class),
 
     /* only for display, no real type */
-    CLOSEDWAY  (marktr("closedway"), null, WayData.class),
-    MULTIPOLYGON (marktr("multipolygon"), null, RelationData.class);
+    CLOSEDWAY  (marktr(/* ICON(data/) */"closedway"), null, WayData.class),
+    MULTIPOLYGON (marktr(/* ICON(data/) */"multipolygon"), null, RelationData.class);
 
     private final String apiTypeName;

trunk/src/org/openstreetmap/josm/data/validation/Severity.java

@@ -12 +12 @@
 public enum Severity {
     /** Error messages */
-    ERROR(tr("Errors"), "error",       Main.pref.getColor(marktr("validation error"), Color.RED)),
+    ERROR(tr("Errors"), /* ICON(data/) */"error",       Main.pref.getColor(marktr("validation error"), Color.RED)),
     /** Warning messages */
-    WARNING(tr("Warnings"), "warning", Main.pref.getColor(marktr("validation warning"), Color.YELLOW)),
+    WARNING(tr("Warnings"), /* ICON(data/) */"warning", Main.pref.getColor(marktr("validation warning"), Color.YELLOW)),
     /** Other messages */
-    OTHER(tr("Other"), "other",        Main.pref.getColor(marktr("validation other"), Color.CYAN));
+    OTHER(tr("Other"), /* ICON(data/) */"other",        Main.pref.getColor(marktr("validation other"), Color.CYAN));
 
     /** Description of the severity code */

trunk/src/org/openstreetmap/josm/gui/ImageryMenu.java

@@ -70 +70 @@
     Map_Rectifier_WMSmenuAction rectaction = new Map_Rectifier_WMSmenuAction();
     JosmAction blankmenu = new JosmAction(
-            tr("Blank Layer"), "blankmenu", tr("Open a blank WMS layer to load data from a file"), null, false) {
+            tr("Blank Layer"), /* ICON */"blankmenu", tr("Open a blank WMS layer to load data from a file"), null, false) {
         @Override
         public void actionPerformed(ActionEvent ev) {

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java

@@ -1158 +1158 @@
                             for (URI u : uris) {
                                 conn = (HttpURLConnection) u.toURL().openConnection();
-                                conn.setConnectTimeout(5000);
+                                conn.setConnectTimeout(Main.pref.getInteger("socket.timeout.connect",15)*1000);
 
                                 if (conn.getResponseCode() != 200) {
@@ -1171 +1171 @@
                                             .replaceFirst("/wiki/", "/w/index.php?redirect=no&title=")
                                     ).toURL().openConnection();
-                                    conn.setConnectTimeout(5000);
+                                    conn.setConnectTimeout(Main.pref.getInteger("socket.timeout.connect",15)*1000);
 
                                     /* redirect pages have different content length, but retrieving a "nonredirect"

trunk/src/org/openstreetmap/josm/gui/download/PlaceSelection.java

@@ -365 +365 @@
                     connection = (HttpURLConnection)url.openConnection();
                 }
-                connection.setConnectTimeout(15000);
+                connection.setConnectTimeout(Main.pref.getInteger("socket.timeout.connect",15)*1000);
                 InputStream inputStream = connection.getInputStream();
                 InputSource inputSource = new InputSource(new InputStreamReader(inputStream, "UTF-8"));

trunk/src/org/openstreetmap/josm/gui/layer/markerlayer/Marker.java

@@ -179 +179 @@
         this.offset = offset;
         this.time = time;
+        // /* ICON(markers/) */"Bridge"
+        // /* ICON(markers/) */"Crossing"
         this.symbol = ImageProvider.getIfAvailable("markers",iconName);
         this.parentLayer = parentLayer;

trunk/src/org/openstreetmap/josm/gui/mappaint/MapPaintStyles.java

@@ -84 +84 @@
         if(i == null)
         {
-            System.out.println("Mappaint style \""+namespace+"\" icon \"" + ref.iconName + "\" not found.");
+            System.out.println("Mappaint style \""+namespace+"\" ("+ref.source.getDisplayString()+") icon \"" + ref.iconName + "\" not found.");
             return null;
         }

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java

@@ -88 +88 @@
 
     public enum PresetType {
-        NODE("Mf_node"), WAY("Mf_way"), RELATION("Mf_relation"), CLOSEDWAY("Mf_closedway");
+        NODE(/* ICON */"Mf_node"), WAY(/* ICON */"Mf_way"), RELATION(/* ICON */"Mf_relation"), CLOSEDWAY(/* ICON */"Mf_closedway");
 
         private final String iconName;

trunk/src/org/openstreetmap/josm/io/MirroredInputStream.java

@@ -65 +65 @@
                 if(Main.applet) {
                     URLConnection conn = url.openConnection();
-                    conn.setConnectTimeout(5000);
-                    conn.setReadTimeout(5000);
+                    conn.setConnectTimeout(Main.pref.getInteger("socket.timeout.connect",15)*1000);
+                    conn.setReadTimeout(Main.pref.getInteger("socket.timeout.read",30)*1000);
                     fs = new BufferedInputStream(conn.getInputStream());
                     file = new File(url.getFile());
@@ -218 +218 @@
         try {
             URLConnection conn = url.openConnection();
-            conn.setConnectTimeout(5000);
-            conn.setReadTimeout(5000);
+            conn.setConnectTimeout(Main.pref.getInteger("socket.timeout.connect",15)*1000);
+            conn.setReadTimeout(Main.pref.getInteger("socket.timeout.read",30)*1000);
             bis = new BufferedInputStream(conn.getInputStream());
             FileOutputStream fos = new FileOutputStream(destDirFile);

trunk/src/org/openstreetmap/josm/io/OsmApi.java

@@ -546 +546 @@
                 System.out.print(requestMethod + " " + url + "... ");
                 activeConnection = (HttpURLConnection)url.openConnection();
-                activeConnection.setConnectTimeout(fastFail ? 1000 : 15000);
+                activeConnection.setConnectTimeout(fastFail ? 1000 : Main.pref.getInteger("socket.timeout.connect",15)*1000);
                 activeConnection.setRequestMethod(requestMethod);
                 if (doAuthenticate) {

trunk/src/org/openstreetmap/josm/io/OsmServerReader.java

@@ -79 +79 @@
             }
 
-            activeConnection.setConnectTimeout(15000);
+            activeConnection.setConnectTimeout(Main.pref.getInteger("socket.timeout.connect",15)*1000);
 
             try {

trunk/src/org/openstreetmap/josm/io/imagery/WMSGrabber.java

@@ -175 +175 @@
         }
         conn.setRequestProperty("User-Agent", Main.pref.get("imagery.wms.user_agent", Version.getInstance().getAgentString()));
-        conn.setConnectTimeout(Main.pref.getInteger("imagery.wms.timeout.connect", 30) * 1000);
-        conn.setReadTimeout(Main.pref.getInteger("imagery.wms.timeout.read", 30) * 1000);
+        conn.setConnectTimeout(Main.pref.getInteger("socket.timeout.connect",15) * 1000);
+        conn.setReadTimeout(Main.pref.getInteger("socket.timeout.read", 30) * 1000);
 
         String contentType = conn.getHeaderField("Content-Type");