Changeset 4032 in josm

Timestamp:

2011-04-16T23:43:53+02:00 (13 years ago)

Author:

stoecker

Message:

allow to define icon and name for search and background layer actions in toolbar

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/AdaptableAction.java (added)
• actions/AddImageryLayerAction.java (modified) (1 diff)
• actions/ParameterizedAction.java (modified) (1 diff)
• gui/preferences/ToolbarPreferences.java (modified) (12 diffs)

trunk/src/org/openstreetmap/josm/actions/AddImageryLayerAction.java

@@ -11 +11 @@
 import org.openstreetmap.josm.gui.layer.ImageryLayer;
 
-public class AddImageryLayerAction extends JosmAction {
+public class AddImageryLayerAction extends JosmAction implements AdaptableAction {
 
     private final ImageryInfo info;

trunk/src/org/openstreetmap/josm/actions/ParameterizedAction.java

@@ -8 +8 @@
 import javax.swing.Action;
 
-public interface ParameterizedAction extends Action {
+public interface ParameterizedAction extends AdaptableAction {
 
     List<ActionParameter<?>> getActionParameters();

trunk/src/org/openstreetmap/josm/gui/preferences/ToolbarPreferences.java

@@ -27 +27 @@
 import java.util.Map;
 
+import javax.swing.AbstractAction;
 import javax.swing.Action;
 import javax.swing.DefaultListCellRenderer;
 import javax.swing.DefaultListModel;
 import javax.swing.Icon;
+import javax.swing.ImageIcon;
 import javax.swing.JButton;
 import javax.swing.JComponent;
@@ -57 +59 @@
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.actions.ActionParameter;
+import org.openstreetmap.josm.actions.AdaptableAction;
 import org.openstreetmap.josm.actions.ParameterizedAction;
 import org.openstreetmap.josm.actions.ParameterizedActionDecorator;
@@ -70 +73 @@
     public static class ActionDefinition {
         private final Action action;
+        private String name = "";
+        private String icon = "";
         private final Map<String, Object> parameters = new HashMap<String, Object>();
 
@@ -89 +94 @@
         public Action getAction() {
             return action;
+        }
+
+        public String getName() {
+            return name;
+        }
+
+        public void setName(String name) {
+            this.name = name;
+            action.putValue(AbstractAction.SHORT_DESCRIPTION, Main.platform.makeTooltip(name, null));
+            action.putValue(AbstractAction.NAME, name);
+        }
+
+        public String getIcon() {
+            return icon;
+        }
+
+        public void setIcon(String icon) {
+            this.icon = icon;
+            ImageIcon ico = ImageProvider.getIfAvailable("", icon);
+            if(ico != null)
+                action.putValue(AbstractAction.SMALL_ICON, ico);
         }
 
@@ -135 +161 @@
             this.s = actionName.toCharArray();
 
-            String name = readTillChar('(', '(');
+            String name = readTillChar('(', '{');
             Action action = actions.get(name);
 
@@ -152 +178 @@
                 }
 
-                do {
+                while (index < s.length && s[index] != ')') {
                     String paramName = readTillChar('=', '=');
                     skip('=');
@@ -163 +189 @@
                     }
                     skip(',');
-                } while (index < s.length && s[index] != ')');
+                }
+                skip(')');
+            }
+            if (action instanceof AdaptableAction) {
+                skip('{');
+
+                while (index < s.length && s[index] != '}') {
+                    String paramName = readTillChar('=', '=');
+                    skip('=');
+                    String paramValue = readTillChar(',','}');
+                    if ("icon".equals(paramName) && paramValue.length() > 0)
+                        result.setIcon(paramValue);
+                    else if("name".equals(paramName) && paramValue.length() > 0)
+                        result.setName(paramValue);
+                    skip(',');
+                }
+                skip('}');
             }
 
@@ -172 +214 @@
             for (int i=0; i<s.length(); i++) {
                 char ch = s.charAt(i);
-                if (ch == '\\' || ch == '(' || ch == ',' || ch == ')' || ch == '=') {
+                if (ch == '\\' || ch == '(' || ch == '{' || ch == ',' || ch == ')' || ch == '}' || ch == '=') {
                     result.append('\\');
                     result.append(ch);
@@ -204 +246 @@
                 }
             }
+            if (action.getAction() instanceof AdaptableAction) {
+                boolean first = true;
+                String tmp = action.getName();
+                if(tmp.length() != 0) {
+                    result.append(first ? "{" : ",");
+                    result.append("name=");
+                    escape(tmp);
+                    first = false;
+                }
+                tmp = action.getIcon();
+                if(tmp.length() != 0) {
+                    result.append(first ? "{" : ",");
+                    result.append("icon=");
+                    escape(tmp);
+                    first = false;
+                }
+                if(!first)
+                    result.append('}');
+            }
 
             return result.toString();
@@ -221 +282 @@
                 return 0;
             ParameterizedAction pa = (ParameterizedAction)currentAction.getAction();
-            return pa.getActionParameters().size();
+            return pa.getActionParameters().size()
+            + ((currentAction.getAction() instanceof ParameterizedAction) ? 2 : 0);
         }
 
@@ -231 +293 @@
 
         public Object getValueAt(int rowIndex, int columnIndex) {
+            if(currentAction.getAction() instanceof ParameterizedAction)
+            {
+                if (rowIndex < 2) {
+                    switch (columnIndex) {
+                    case 0:
+                        return rowIndex == 0 ? tr("Tooltip") : tr("Icon");
+                    case 1:
+                        return rowIndex == 0 ? currentAction.getName() : currentAction.getIcon();
+                    default:
+                        return null;
+                    }
+                } else
+                    rowIndex -= 2;
+            }
             ActionParameter<Object> param = getParam(rowIndex);
             switch (columnIndex) {
@@ -249 +325 @@
         @Override
         public void setValueAt(Object aValue, int rowIndex, int columnIndex) {
+            if(currentAction.getAction() instanceof ParameterizedAction)
+            {
+                if (rowIndex == 0) {
+                     currentAction.setName((String)aValue);
+                     return;
+                } else if (rowIndex == 1) {
+                     currentAction.setIcon((String)aValue);
+                     return;
+                } else
+                    rowIndex -= 2;
+            }
             ActionParameter<Object> param = getParam(rowIndex);
             currentAction.getParameters().put(param.getName(), param.readFromString((String)aValue));