Changeset 36463 in osm for applications/editors/josm/plugins/photoadjust/src

Timestamp:

2025-11-06T16:11:22+01:00 (6 weeks ago)

Author:

GerdP

Message:

fix #21523: Setting the direction of a panned 360 photo causes a counterintuitive result

• apply photoadjust_21523_fix_direction_360.patch by gillux: "The arrow direction does not display the exif direction angle, instead it displays exif angle + image viewer angle. So when the plugin sets the exif angle from the arrow direction, it needs to substract the image viewer angle from it."
• remove targets from build.xml which invoke perl or overwrite the code to build javadoc

File:

• applications/editors/josm/plugins/photoadjust/src/org/openstreetmap/josm/plugins/photoadjust/PhotoAdjustWorker.java (modified) (2 diffs)

applications/editors/josm/plugins/photoadjust/src/org/openstreetmap/josm/plugins/photoadjust/PhotoAdjustWorker.java

@@ -16 +16 @@
 import org.openstreetmap.josm.gui.layer.geoimage.ImageEntry;
 import org.openstreetmap.josm.gui.layer.geoimage.ImageViewerDialog;
+import org.openstreetmap.josm.gui.util.imagery.Vector3D;
+import org.openstreetmap.josm.tools.Utils;
 
 /**
@@ -240 +242 @@
         }
         final LatLon mouseLL = MainApplication.getMap().mapView.getLatLon(evt.getX(), evt.getY());
+        Vector3D viewerVector = ImageViewerDialog.getInstance().getRotation(photo);
+        double viewerAngle = viewerVector != null ? Utils.toDegrees(viewerVector.getPolarAngle()) : 0d;
         // The projection doesn't matter here.
-        double direction = photoLL.bearing(mouseLL) * 360.0 / 2.0 / Math.PI;
+        double direction = photoLL.bearing(mouseLL) * 360.0 / 2.0 / Math.PI - viewerAngle;
         if (direction < 0.0) {
             direction += 360.0;