Changeset 36450 in osm

Timestamp:

2025-05-25T14:20:39+02:00 (8 weeks ago)

Author:

stoecker

Message:

see #24238 - add more unit tests

File:

• applications/editors/josm/plugins/photo_geotagging/test/unit/org/openstreetmap/josm/plugins/photo_geotagging/ExifGPSTaggerTest.java (modified) (3 diffs)

applications/editors/josm/plugins/photo_geotagging/test/unit/org/openstreetmap/josm/plugins/photo_geotagging/ExifGPSTaggerTest.java

@@ -22 +22 @@
 import org.openstreetmap.josm.data.coor.LatLon;
 import org.openstreetmap.josm.gui.layer.geoimage.ImageEntry;
+import org.openstreetmap.josm.tools.ExifReader;
 
 class ExifGPSTaggerTest {
@@ -73 +74 @@
 
     @Test
-    public void testTicket24278() {
+    public void testTicket24278() throws Exception{
         final File in = new File(TestUtils.getTestDataRoot(), "_DSC1234.jpg");
         final File out = new File(tempFolder, in.getName());
         final ImageEntry image = newImageEntry("test", 12d, 34d, Instant.now(), 12.34d, Math.E, Math.PI);
-        image.setExifGpsTrack(Math.PI);
-        image.setGpsDiffMode(2);
+        image.setExifGpsTrack(97.99);
+        image.setGpsDiffMode(1);
         image.setGps2d3dMode(3);
         image.setExifGpsProcMethod("GPS");
@@ -84 +85 @@
         image.setExifGpsDop(2.5d);
         image.setExifGpsDatum("WGS84");
-        assertDoesNotThrow(() -> ExifGPSTagger.setExifGPSTag(in, out, image, true));
-        /* TODO read temp file and assertEquals EXIF metadata values */
+        ExifGPSTagger.setExifGPSTag(in, out, image, true);
+        assertEquals(Math.PI, ExifReader.readDirection(out), 0.001);
+        assertEquals(97.99, ExifReader.readGpsTrackDirection(out));
+        assertEquals(1, ExifReader.readGpsDiffMode(out));
+        assertEquals(3, ExifReader.readGpsMeasureMode(out));
+        assertEquals("GPS", ExifReader.readGpsProcessingMethod(out));
+        assertEquals(1.2, ExifReader.readHpositioningError(out));
+        assertEquals(2.5, ExifReader.readGpsDop(out));
+        assertEquals("WGS84", ExifReader.readGpsDatum(out));
     }
 }