Changeset 36440 in osm

Timestamp:

2025-05-02T21:05:20+02:00 (6 days ago)

Author:

stoecker

Message:

some checkstyle fixes

Location:

applications/editors/josm/plugins/opendata/src/org/openstreetmap/josm/plugins/opendata/core

Files:

• datasets/AbstractDataSetHandler.java (modified) (1 diff)
• datasets/SimpleDataSetHandler.java (modified) (1 diff)
• datasets/fr/FrenchDataSetHandler.java (modified) (2 diffs)
• io/archive/CandidateChooser.java (modified) (1 diff)
• io/geographic/MifReader.java (modified) (1 diff)
• io/session/OpenDataSessionExporter.java (modified) (1 diff)
• io/session/OpenDataSessionImporter.java (modified) (1 diff)
• modules/ModuleHandler.java (modified) (2 diffs)

applications/editors/josm/plugins/opendata/src/org/openstreetmap/josm/plugins/opendata/core/datasets/AbstractDataSetHandler.java

@@ -89 +89 @@
     }
 
-    private static boolean acceptsFilename(String filename, String[] expected, String ... extensions) {
+    private static boolean acceptsFilename(String filename, String[] expected, String... extensions) {
         if (filename != null) {
             for (String expectedName : expected) {

applications/editors/josm/plugins/opendata/src/org/openstreetmap/josm/plugins/opendata/core/datasets/SimpleDataSetHandler.java

@@ -65 +65 @@
     }
 
-    protected SimpleDataSetHandler(boolean relevantUnion, Tag ... relevantTags) {
+    protected SimpleDataSetHandler(boolean relevantUnion, Tag... relevantTags) {
         addRelevantTag(relevantTags);
         this.relevantUnion = relevantUnion;

applications/editors/josm/plugins/opendata/src/org/openstreetmap/josm/plugins/opendata/core/datasets/fr/FrenchDataSetHandler.java

@@ -118 +118 @@
 
     protected static LatLon getLatLonByDptCode(EastNorth en, String dpt, boolean useCC9) {
+        // CHECKSTYLE.OFF: BooleanExpressionComplexity
         // CHECKSTYLE.OFF: LineLength
         if (dpt.equals("971") || dpt.equals("972") || dpt.equals("977") || dpt.equals("978")) {    // Antilles
@@ -151 +152 @@
         }
         // CHECKSTYLE.ON: LineLength
+        // CHECKSTYLE.ON: BooleanExpressionComplexity
     }
 

applications/editors/josm/plugins/opendata/src/org/openstreetmap/josm/plugins/opendata/core/io/archive/CandidateChooser.java

@@ -33 +33 @@
     }
 
-    private static class Renderer extends DefaultListCellRenderer {
+    private final static class Renderer extends DefaultListCellRenderer {
 
         @Override

applications/editors/josm/plugins/opendata/src/org/openstreetmap/josm/plugins/opendata/core/io/geographic/MifReader.java

@@ -144 +144 @@
 
         // Origin, latitude
-        switch(proj) {
+        switch (proj) {
         case Albers_Equal_Area_Conic:
         case Azimuthal_Equidistant_polar_aspect_only:

applications/editors/josm/plugins/opendata/src/org/openstreetmap/josm/plugins/opendata/core/io/session/OpenDataSessionExporter.java

@@ +1 @@
+// License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.plugins.opendata.core.io.session;
 

applications/editors/josm/plugins/opendata/src/org/openstreetmap/josm/plugins/opendata/core/io/session/OpenDataSessionImporter.java

@@ +1 @@
+// License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.plugins.opendata.core.io.session;
 

applications/editors/josm/plugins/opendata/src/org/openstreetmap/josm/plugins/opendata/core/modules/ModuleHandler.java

@@ -169 +169 @@
 
         if (pnlMessage.isRememberDecision()) {
-            switch(ret) {
+            switch (ret) {
             case 0:
                 Config.getPref().put(togglePreferenceKey, "always");
@@ -331 +331 @@
                 ret.put(pi.name, pi);
             }
-            return ret;
+            return Collections.unmodifiableMap(ret);
         } finally {
             monitor.finishTask();