Changeset 36248 in osm

Timestamp:

2024-04-16T15:58:38+02:00 (7 months ago)

Author:

taylor.smock

Message:

Cache record component accesses in FIT plugin to reduce CPU cost

File:

• applications/editors/josm/plugins/FIT/src/main/java/org/openstreetmap/josm/plugins/fit/FitPlugin.java (modified) (3 diffs)

applications/editors/josm/plugins/FIT/src/main/java/org/openstreetmap/josm/plugins/fit/FitPlugin.java

@@ -11 +11 @@
 import java.util.Arrays;
 import java.util.Collections;
+import java.util.HashMap;
 import java.util.TreeMap;
 import java.util.concurrent.TimeUnit;
@@ -55 +56 @@
         @Override
         public void importData(File file, ProgressMonitor progressMonitor) throws IOException {
+            final var fieldMap = new HashMap<Class<? extends Record>, RecordComponent[]>(1);
             try (var inputStream = Files.newInputStream(file.toPath())) {
                 final var records = FitReader.read(inputStream, FitReaderOptions.TRY_TO_FINISH);
@@ -73 +75 @@
                             // Use a sorted map for consistency
                             final var map = new TreeMap<String, Object>();
-                            for (RecordComponent component : HeartRateCadenceDistanceSpeed.class
-                                    .getRecordComponents()) {
+                            for (RecordComponent component : fieldMap.computeIfAbsent(HeartRateCadenceDistanceSpeed.class,
+                                    Class::getRecordComponents)) {
                                 if (Arrays.asList("lat", "lon", "timestamp", "unknown").contains(component.getName())) {
                                     continue; // skip information that has specific fields