Changeset 36168 in osm for applications/editors/josm

Timestamp:

2023-10-11T15:18:18+02:00 (12 months ago)

Author:

taylor.smock

Message:

See #23218: Fix disabling coverage when coverage will not work (JDK 21)

When jacoco was disabled, the property jacocoagent was set to '', which added
a JVM argument '', which Java believed should be a class file. This caused the
following message:

[junitlauncher] Error: Could not find or load main class 
[junitlauncher] Caused by: java.lang.ClassNotFoundException: 

Note that both of those lines have a space at the end, but no useful information
since the class the JVM was trying to load was an empty string.

File:

• applications/editors/josm/plugins/build-common.xml (modified) (1 diff)

applications/editors/josm/plugins/build-common.xml

@@ -600 +600 @@
         <sequential>
             <echo message="Running unit tests with JUnit"/>
-            <jacoco:agent destfile="${plugin.test.dir}/jacoco.exec" enabled="${coverageByDefault}" inclbootstrapclasses="${jacoco.inclbootstrapclasses}" inclnolocationclasses="${jacoco.inclnolocationclasses}" property="jacocoagent"/>
+            <jacoco:agent destfile="${plugin.test.dir}/jacoco.exec" enabled="${coverageByDefault}"
+                          inclbootstrapclasses="${jacoco.inclbootstrapclasses}" inclnolocationclasses="${jacoco.inclnolocationclasses}"
+                          property="jacocoagent" if:true="${coverageByDefault}"/>
             <junitlauncher printsummary="${junit.printsummary}">
                 <classpath>