Changeset 36071 in osm for applications/editors/josm/plugins

Timestamp:

2023-04-19T15:04:07+02:00 (19 months ago)

Author:

taylor.smock

Message:

opendata: Load all layers from a geopackage file

Location:

applications/editors/josm/plugins/opendata/src/org/openstreetmap/josm/plugins/opendata/core/io/geographic

Files:

• GeotoolsConverter.java (modified) (1 diff)
• geopackage/GeoPackageReader.java (modified) (1 diff)

applications/editors/josm/plugins/opendata/src/org/openstreetmap/josm/plugins/opendata/core/io/geographic/GeotoolsConverter.java

@@ -75 +75 @@
             throws IOException, FactoryException, GeoMathTransformException, TransformException, GeoCrsException {
         String[] typeNames = dataStore.getTypeNames();
-        String typeName = typeNames[0];
-
-        FeatureSource<?, ?> featureSource = dataStore.getFeatureSource(typeName);
-        FeatureCollection<?, ?> collection = featureSource.getFeatures();
-
+        if (progressMonitor != null) {
+            progressMonitor.beginTask(tr("Loading shapefile ({0} layers)", typeNames.length), typeNames.length);
+        }
+        try {
+            for (String typeName : typeNames) {
+                FeatureSource<?, ?> featureSource = dataStore.getFeatureSource(typeName);
+                FeatureCollection<?, ?> collection = featureSource.getFeatures();
+                parseFeatures(progressMonitor != null ? progressMonitor.createSubTaskMonitor(1, false) : null, collection);
+            }
+        } finally {
+            if (progressMonitor != null) {
+                progressMonitor.finishTask();
+            }
+        }
+    }
+
+    /**
+     * Run the actual conversion process for a collection of features
+     * @param progressMonitor The monitor to show progress on
+     * @param collection The collection to parse
+     * @throws FactoryException See {@link GeographicReader#findMathTransform(Component, boolean)}
+     * @throws GeoMathTransformException See {@link GeographicReader#findMathTransform(Component, boolean)}
+     * @throws TransformException See {@link GeographicReader#createOrGetNode(Point)}
+     * @throws GeoCrsException If the CRS cannot be detected
+     */
+    private void parseFeatures(ProgressMonitor progressMonitor, FeatureCollection<?, ?> collection)
+            throws FactoryException, GeoMathTransformException, TransformException, GeoCrsException {
         if (progressMonitor != null) {
             progressMonitor.beginTask(tr("Loading shapefile ({0} features)", collection.size()), collection.size());

applications/editors/josm/plugins/opendata/src/org/openstreetmap/josm/plugins/opendata/core/io/geographic/geopackage/GeoPackageReader.java

@@ -60 +60 @@
             } catch (FactoryException | GeoCrsException | GeoMathTransformException | TransformException e) {
                 throw new IOException(e);
+            } finally {
+                dataStore.dispose();
             }
         }