Changeset 36063 in osm

Timestamp:

2023-03-13T21:59:31+01:00 (20 months ago)

Author:

taylor.smock

Message:

See #16567: Convert all assertion calls to JUnit 5 (patch by gaben, modified)

The modifications are as follows:

• Merge DomainValidatorTest.testIDN and DomainValidatorTest.testIDNJava6OrLater
• Update some tests to use @ParameterizedTest (DomainValidatorTest)
• Replace various exception blocks with assertThrows. These typically looked like

      try {
          // Something that should throw an exception here
          fail("An exception should have been thrown");
      } catch (Exception e) {
          // Verify the exception matches expectations here
      }
  

• Replace assertTrue(val instanceof Clazz) with assertInstanceOf
• Replace JUnit 4 @Suite with JUnit 5 @Suite

Both the original patch and the modified patch fix various lint issues.

File:

• applications/editors/josm/plugins/CustomizePublicTransportStop/JOSM-CustomizePublicTransportStop.iml (modified) (1 diff)

applications/editors/josm/plugins/CustomizePublicTransportStop/JOSM-CustomizePublicTransportStop.iml

@@ -11 +11 @@
     <orderEntry type="sourceFolder" forTests="false" />
     <orderEntry type="inheritedJdk" />
-    <orderEntry type="library" name="josm-tested" level="project" />
+    <orderEntry type="module" module-name="JOSM" />
   </component>
 </module>