Changeset 35869 in osm for applications/editors/josm/plugins

Timestamp:

2021-11-28T09:05:10+01:00 (2 years ago)

Author:

GerdP

Message:

fix #21589: Reverter plugin exception: IllegalArgumentException

• detect conflicts created by download of missing members and stop revert with notification

Not really a fix, more a "Give up, don't know how to continue". Maybe we should simply not allow reverts in layers which already contain data.

File:

• applications/editors/josm/plugins/reverter/src/reverter/RevertChangesetTask.java (modified) (5 diffs)

applications/editors/josm/plugins/reverter/src/reverter/RevertChangesetTask.java

@@ -98 +98 @@
                 newLayer = false; // reuse layer for subsequent reverts
             } catch (OsmTransferException e) {
-                rollback(allcmds);
+                rollback(allcmds);
                 Logging.error(e);
                 throw e;
             } catch (UserCancelException e) {
-                rollback(allcmds);
+                rollback(allcmds);
                 GuiHelper.executeByMainWorkerInEDT(() -> new Notification(tr("Revert was canceled")).show());
                 Logging.trace(e);
@@ -140 +140 @@
         if (progressMonitor.isCanceled())
             throw new UserCancelException();
-
+        int numOldConflicts = oldDataSet == null ? 0 : oldDataSet.getConflicts().size();
         // Check missing objects
         rev.checkMissingCreated();
@@ -154 +154 @@
             rev.downloadMissingPrimitives(progressMonitor.createSubTaskMonitor(ProgressMonitor.ALL_TICKS, false));
         }
+        int numConflicts = oldDataSet == null ? 0 : oldDataSet.getConflicts().size();
+        if (numConflicts > numOldConflicts) {
+            GuiHelper.runInEDT(() -> new Notification(tr("Please solve conflicts and maybe try again to revert."))
+            .setIcon(JOptionPane.ERROR_MESSAGE)
+            .show());
+            return null;
+        }
 
         if (progressMonitor.isCanceled())
@@ -173 +180 @@
         }
         GuiHelper.runInEDT(() -> {
-                for (Command c : cmds) {
-                        if (c instanceof ConflictAddCommand) {
-                                numberOfConflicts++;
-                        }
-                        c.executeCommand();
-                }
+            for (Command c : cmds) {
+                if (c instanceof ConflictAddCommand) {
+                    numberOfConflicts++;
+                }
+                c.executeCommand();
+            }
         });
         final String desc;
@@ -189 +196 @@
     }
 
-        @Override
-        protected void cancel() {
+    @Override
+    protected void cancel() {
         // nothing to do
-        }
-
-        @Override
-        protected void finish() {
+    }
+
+    @Override
+    protected void finish() {
         // nothing to do
 
-        }
+    }
 
     /**