Changeset 35627 in osm

Timestamp:

2020-10-29T00:14:19+01:00 (3 years ago)

Author:

simon04

Message:

Add EditLevel0LActionTest

Location:

applications/editors/josm/plugins/comfort0

Files:

• src/net/simon04/comfort0/EditLevel0LAction.java (modified) (2 diffs)
• test/unit/net/simon04/comfort0/EditLevel0LActionTest.java (added)

applications/editors/josm/plugins/comfort0/src/net/simon04/comfort0/EditLevel0LAction.java

@@ -107 +107 @@
     static List<PrimitiveData> readLevel0(Reader reader, final DataSet dataSet) throws ParseException {
         final List<PrimitiveData> primitives = new Level0LParser(reader).primitives();
-        buildChangeCommands(dataSet, primitives);
+        final SequenceCommand command = buildChangeCommands(dataSet, primitives);
+        GuiHelper.runInEDT(() -> {
+            if (command == null || command.getChildren().isEmpty()) {
+                return;
+            }
+            new Notification(trn(
+                    "Comfort0: Changing {0} primitive",
+                    "Comfort0: Changing {0} primitives", command.getChildren().size(), command.getChildren().size())).show();
+            UndoRedoHandler.getInstance().add(command);
+        });
         return primitives;
     }
 
-    static void buildChangeCommands(DataSet dataSet, List<PrimitiveData> primitives) {
+    static SequenceCommand buildChangeCommands(DataSet dataSet, List<PrimitiveData> primitives) {
         final List<Command> commands = new ArrayList<>();
         for (PrimitiveData fromLevel0L : primitives) {
@@ -132 +141 @@
             }
         }
-
         if (commands.isEmpty()) {
-            return;
+            return null;
         }
-        final SequenceCommand command = new SequenceCommand("Comfort0", commands);
-        GuiHelper.runInEDT(() -> {
-            new Notification(trn(
-                    "Comfort0: Changing {0} primitive",
-                    "Comfort0: Changing {0} primitives", commands.size(), commands.size())).show();
-            UndoRedoHandler.getInstance().add(command);
-        });
+        return new SequenceCommand("Comfort0", commands);
     }
 }