Changeset 3559 in josm for trunk/src/org/openstreetmap/josm/data

Timestamp:

2010-09-24T08:50:03+02:00 (14 years ago)

Author:

bastiK

Message:

autosave: fix issues with deleting autosaved layers on start

File:

• trunk/src/org/openstreetmap/josm/data/AutosaveTask.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/AutosaveTask.java

@@ -221 +221 @@
                             File lastFile = info.backupFiles.pollLast();
                             if (lastFile != null) {
-                                File backupFile = new File(deletedLayersDir, lastFile.getName());
-                                lastFile.renameTo(backupFile);
-                                deletedLayers.add(lastFile);
+                                moveToDeletedLayersFolder(lastFile);
                             }
                             for (File file: info.backupFiles) {
                                 file.delete();
-                            }
-
-                            while (deletedLayers.size() > PROP_DELETED_LAYERS.get()) {
-                                deletedLayers.remove().delete();
                             }
                         } catch (IOException e) {
@@ -270 +264 @@
                 layerName = layerName.substring(0, layerName.lastIndexOf('.'));
                 result.add(new OsmDataLayer(ds, layerName, null));
-                f.renameTo(new File(deletedLayersDir, f.getName()));
+                moveToDeletedLayersFolder(f);
             } catch (FileNotFoundException e) {
                 // Should not happen
@@ -282 +276 @@
     }
 
+    private void moveToDeletedLayersFolder(File f) {
+        File backupFile = new File(deletedLayersDir, f.getName());
+        if (backupFile.exists()) {
+            deletedLayers.remove(backupFile);
+            backupFile.delete();
+        }
+        if (f.renameTo(backupFile)) {
+            deletedLayers.add(backupFile);
+        } else {
+            System.err.println(String.format("Warning: Could not move autosaved file %s to %s folder", f.getName(), deletedLayersDir.getName()));
+            f.delete();
+        }
+        while (deletedLayers.size() > PROP_DELETED_LAYERS.get()) {
+            deletedLayers.remove().delete();
+        }
+    }
+
     public void dicardUnsavedLayers() {
         for (File f: getUnsavedLayersFiles()) {
-            f.renameTo(new File(deletedLayersDir, f.getName()));
-        }
-    }
-
+            moveToDeletedLayersFolder(f);
+        }
+    }
 }