Changeset 35161 in osm for applications

Timestamp:

2019-09-29T22:11:59+02:00 (5 years ago)

Author:

donvip

Message:

more lambdas

Location:

applications/editors/josm/plugins/geochat/src/geochat

Files:

• ChatMessage.java (modified) (1 diff)
• ChatPaneManager.java (modified) (4 diffs)
• ChatServerConnection.java (modified) (5 diffs)
• GeoChatPanel.java (modified) (2 diffs)
• JsonQueryCallback.java (modified) (1 diff)

applications/editors/josm/plugins/geochat/src/geochat/ChatMessage.java

@@ -77 +77 @@
     @Override
     public boolean equals(Object obj) {
-        if (obj == null) {
-            return false;
-        }
-        if (getClass() != obj.getClass()) {
+        if (obj == null || getClass() != obj.getClass()) {
             return false;
         }

applications/editors/josm/plugins/geochat/src/geochat/ChatPaneManager.java

@@ -16 +16 @@
 import javax.swing.JTabbedPane;
 import javax.swing.JTextPane;
-import javax.swing.event.ChangeEvent;
-import javax.swing.event.ChangeListener;
 import javax.swing.text.BadLocationException;
 import javax.swing.text.Document;
@@ -45 +43 @@
         chatPanes = new HashMap<>();
         createChatPane(null);
-        tabs.addChangeListener(new ChangeListener() {
-            @Override
-            public void stateChanged(ChangeEvent e) {
-                updateActiveTabStatus();
-            }
-        });
+        tabs.addChangeListener(e -> updateActiveTabStatus());
     }
 
@@ -90 +83 @@
     }
 
-    public static int MESSAGE_TYPE_DEFAULT = 0;
-    public static int MESSAGE_TYPE_INFORMATION = 1;
-    public static int MESSAGE_TYPE_ATTENTION = 2;
-    private static Color COLOR_ATTENTION = new Color(0, 0, 192);
+    public static final int MESSAGE_TYPE_DEFAULT = 0;
+    public static final int MESSAGE_TYPE_INFORMATION = 1;
+    public static final int MESSAGE_TYPE_ATTENTION = 2;
+    private static final Color COLOR_ATTENTION = new Color(0, 0, 192);
 
     private void addLineToChatPane(String userName, String line, final int messageType) {
-        if (line.length() == 0)
+        if (line.isEmpty())
             return;
         if (!chatPanes.containsKey(userName))
@@ -261 +254 @@
         public JScrollPane component;
         public int notify;
-
     }
 }

applications/editors/josm/plugins/geochat/src/geochat/ChatServerConnection.java

@@ -95 +95 @@
         } else {
             String query = "whoami&uid=" + uid;
-            JsonQueryUtil.queryAsync(query, new JsonQueryCallback() {
-                @Override
-                public void processJson(JsonObject json) {
-                    if (json != null && json.get("name") != null)
-                        login(uid, json.getString("name"));
-                    else if (userName != null && userName.length() > 1)
-                        login(userName);
-                }
+            JsonQueryUtil.queryAsync(query, json -> {
+                if (json != null && json.get("name") != null)
+                    login(uid, json.getString("name"));
+                else if (userName != null && userName.length() > 1)
+                    login(userName);
             });
         }
@@ -112 +109 @@
      */
     public void autoLoginWithDelay(final String userName) {
-        if (userName == null || userName.length() == 0) {
+        if (userName == null || userName.isEmpty()) {
             checkLogin();
             return;
@@ -148 +145 @@
             + "&lon=" + DecimalDegreesCoordinateFormat.INSTANCE.lonToString(pos)
             + nameAttr;
-            JsonQueryUtil.queryAsync(query, new JsonQueryCallback() {
-                @Override
-                public void processJson(JsonObject json) {
-                    if (json == null)
-                        fireLoginFailed(tr("Could not get server response, check logs"));
-                    else if (json.get("error") != null)
-                        fireLoginFailed(tr("Failed to login as {0}:", userName) + "\n" + json.getString("error"));
-                    else if (json.get("uid") == null)
-                        fireLoginFailed(tr("The server did not return user ID"));
-                    else {
-                        String name = json.get("name") != null ? json.getString("name") : userName;
-                        login(json.getInt("uid"), name);
-                    }
+            JsonQueryUtil.queryAsync(query, json -> {
+                if (json == null)
+                    fireLoginFailed(tr("Could not get server response, check logs"));
+                else if (json.get("error") != null)
+                    fireLoginFailed(tr("Failed to login as {0}:", userName) + "\n" + json.getString("error"));
+                else if (json.get("uid") == null)
+                    fireLoginFailed(tr("The server did not return user ID"));
+                else {
+                    String name = json.get("name") != null ? json.getString("name") : userName;
+                    login(json.getInt("uid"), name);
                 }
             });
@@ -199 +193 @@
             return;
         String query = "logout&uid=" + userId;
-        JsonQueryUtil.queryAsync(query, new JsonQueryCallback() {
-            @Override
-            public void processJson(JsonObject json) {
-                if (json != null && json.get("message") != null) {
-                    logoutIntl();
-                }
+        JsonQueryUtil.queryAsync(query, json -> {
+            if (json != null && json.get("message") != null) {
+                logoutIntl();
             }
         });
@@ -256 +247 @@
             if (targetUser != null && targetUser.length() > 0)
                 query += "&to=" + URLEncoder.encode(targetUser, "UTF8");
-            JsonQueryUtil.queryAsync(query, new JsonQueryCallback() {
-                @Override
-                public void processJson(JsonObject json) {
-                    if (json == null)
-                        fireMessageFailed(tr("Could not get server response, check logs"));
-                    else if (json.get("error") != null)
-                        fireMessageFailed(json.getString("error"));
-                }
+            JsonQueryUtil.queryAsync(query, json -> {
+                if (json == null)
+                    fireMessageFailed(tr("Could not get server response, check logs"));
+                else if (json.get("error") != null)
+                    fireMessageFailed(json.getString("error"));
             });
         } catch (UnsupportedEncodingException e) {

applications/editors/josm/plugins/geochat/src/geochat/GeoChatPanel.java

@@ -17 +17 @@
 import java.awt.Point;
 import java.awt.RenderingHints;
-import java.awt.event.ActionEvent;
-import java.awt.event.ActionListener;
 import java.io.IOException;
 import java.text.SimpleDateFormat;
@@ -123 +121 @@
 
         JButton loginButton = new JButton(tr("Login"));
-        loginButton.addActionListener(new ActionListener() {
-            @Override
-            public void actionPerformed(ActionEvent e) {
-                connection.login(nameField.getText());
-            }
-        });
+        loginButton.addActionListener(e -> connection.login(nameField.getText()));
         nameField.setPreferredSize(new Dimension(nameField.getPreferredSize().width, loginButton.getPreferredSize().height));
 
         final JCheckBox autoLoginBox = new JCheckBox(tr("Enable autologin"), Config.getPref().getBoolean("geochat.autologin", true));
-        autoLoginBox.addActionListener(new ActionListener() {
-            @Override
-            public void actionPerformed(ActionEvent e) {
-                Config.getPref().putBoolean("geochat.autologin", autoLoginBox.isSelected());
-            }
-        });
+        autoLoginBox.addActionListener(e -> Config.getPref().putBoolean("geochat.autologin", autoLoginBox.isSelected()));
 
         JPanel panel = new JPanel(new GridBagLayout());

applications/editors/josm/plugins/geochat/src/geochat/JsonQueryCallback.java

@@ -9 +9 @@
  * @author zverik
  */
+@FunctionalInterface
 public interface JsonQueryCallback {