Changeset 3453 in josm for trunk

Timestamp:

2010-08-21T14:59:31+02:00 (14 years ago)

Author:

bastiK

Message:

suppress some trivial warnings

Location:

trunk/src/org/openstreetmap/josm/data/osm

Files:

• QuadBuckets.java (modified) (2 diffs)
• Storage.java (modified) (8 diffs)

trunk/src/org/openstreetmap/josm/data/osm/QuadBuckets.java

@@ -575 +575 @@
         return true;
     }
-    // If anyone has suggestions for how to fix
-    // this properly, I'm listening :)
-    @SuppressWarnings("unchecked")
-    private T convert(Object raw)
-    {
-        return (T)raw;
-    }
     public boolean remove(Object o) {
-        return this.remove(convert(o));
-    }
-    public boolean remove(T o) {
+        @SuppressWarnings("unchecked") T t = (T) o;
         synchronized (split_lock) {
             search_cache = null; // Search cache might point to one of removed buckets
-            QBLevel bucket = root.findBucket(o.getBBox());
-            if (bucket.remove_content(o)) {
+            QBLevel bucket = root.findBucket(t.getBBox());
+            if (bucket.remove_content(t)) {
                 size--;
                 return true;
@@ -597 +588 @@
     }
     public boolean contains(Object o) {
-        QBLevel bucket = root.findBucket(convert(o).getBBox());
-        return bucket != null && bucket.content != null && bucket.content.contains(o);
+        @SuppressWarnings("unchecked") T t = (T) o;
+        QBLevel bucket = root.findBucket(t.getBBox());
+        return bucket != null && bucket.content != null && bucket.content.contains(t);
     }
 

trunk/src/org/openstreetmap/josm/data/osm/Storage.java

@@ -111 +111 @@
         this.hash = ha;
         int cap = 1 << (int)(Math.ceil(Math.log(capacity/loadFactor) / Math.log(2)));
-        data = (T[]) new Object[cap];
+        @SuppressWarnings("unchecked") T[] newData = (T[]) new Object[cap];
+        data = newData;
         mask = data.length - 1;
         this.safeIterator = safeIterator;
@@ -118 +119 @@
     private void copyArray() {
         if (arrayCopyNecessary) {
-            T[] newData = (T[]) new Object[data.length];
+            @SuppressWarnings("unchecked") T[] newData = (T[]) new Object[data.length];
             System.arraycopy(data, 0, newData, 0, data.length);
             data = newData;
@@ -143 +144 @@
     @Override
     public synchronized boolean contains(Object o) {
-        int bucket = getBucket(hash, (T)o);
+        @SuppressWarnings("unchecked") T t = (T) o;
+        int bucket = getBucket(hash, t);
         return bucket >= 0;
     }
@@ -155 +157 @@
     @Override
     public synchronized boolean remove(Object o) {
-        T orig = removeElem((T)o);
-        return orig != null;
+        @SuppressWarnings("unchecked") T t = (T) o;
+        T tOrig = removeElem(t);
+        return tOrig != null;
     }
     
@@ -292 +295 @@
     private void ensureSpace() {
         if (size > data.length*loadFactor) { // rehash
-            T[] big = (T[]) new Object[data.length * 2];
+            @SuppressWarnings("unchecked") T[] big = (T[]) new Object[data.length * 2];
             int nMask = big.length - 1;
 
@@ -355 +358 @@
         }
 
-        public boolean containsKey(Object key) {
-            int bucket = getBucket(fHash, (K)key);
+        public boolean containsKey(Object o) {
+            @SuppressWarnings("unchecked") K key = (K) o;
+            int bucket = getBucket(fHash, key);
             return bucket >= 0;
         }
@@ -364 +368 @@
         }
 
-        public T get(Object key) {
-            int bucket = getBucket(fHash, (K)key);
+        public T get(Object o) {
+            @SuppressWarnings("unchecked") K key = (K) o;
+            int bucket = getBucket(fHash, key);
             return bucket < 0 ? null : data[bucket];
         }
@@ -374 +379 @@
         }
 
-        public T remove(Object key) {
+        public T remove(Object o) {
             modCount++;
-            int bucket = getBucket(fHash,(K)key);
+            @SuppressWarnings("unchecked") K key = (K) o;
+            int bucket = getBucket(fHash, key);
 
             return bucket < 0 ? null : doRemove(bucket);