Changeset 3422 in josm for trunk

Timestamp:

2010-08-08T13:45:20+02:00 (14 years ago)

Author:

stoecker

Message:

fix #4401 - upload error - patch by Upliner

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/osm/DataSet.java (modified) (1 diff)
• gui/io/UploadPrimitivesTask.java (modified) (4 diffs)
• io/DiffResultProcessor.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/osm/DataSet.java

@@ -918 +918 @@
             while (it.hasNext()) {
                 OsmPrimitive primitive = it.next();
-                if (primitive.isDeleted()) {
+                if (primitive.isDeleted() && !primitive.isVisible()) {
                     selectedPrimitives.remove(primitive);
                     selectionSnapshot = null;

trunk/src/org/openstreetmap/josm/gui/io/UploadPrimitivesTask.java

@@ -235 +235 @@
                     }
                     writer.uploadOsm(strategy, toUpload.getPrimitives(), changeset, getProgressMonitor().createSubTaskMonitor(1, false));
-                    processedPrimitives.addAll(writer.getProcessedPrimitives());
 
                     // if we get here we've successfully uploaded the data. Exit the loop.
@@ -243 +242 @@
                     e.printStackTrace();
                     uploadCancelled = true;
-                    return;
+                    break uploadloop;
                 } catch(OsmApiPrimitiveGoneException e) {
                     // try to recover from  410 Gone
@@ -273 +272 @@
                     }
                 } finally {
+                    if (writer != null) {
+                        processedPrimitives.addAll(writer.getProcessedPrimitives());
+                    }
                     synchronized(this) {
                         writer = null;
@@ -286 +288 @@
             if (uploadCancelled) {
                 System.out.println(tr("Ignoring caught exception because upload is canceled. Exception is: {0}", e.toString()));
-                return;
-            }
-            lastException = e;
-        }
-        if (uploadCancelled) return;
+            } else {
+                lastException = e;
+            }
+        }
+        if (uploadCancelled && processedPrimitives.isEmpty()) return;
         cleanupAfterUpload();
     }

trunk/src/org/openstreetmap/josm/io/DiffResultProcessor.java

@@ -126 +126 @@
                     p.setOsmId(entry.new_id, entry.new_version);
                     p.setVisible(true);
+                } else {
+                    p.setVisible(false);
                 }
                 if (cs != null && !cs.isNew()) {