Changeset 33258 in osm for applications/editors

Timestamp:

2017-04-17T02:17:09+02:00 (7 years ago)

Author:

donvip

Message:

fix #josm13345 - IAE: Listener was not registered before: LayerChangeAdapter (GPSBlamMode)

Location:

applications/editors/josm/plugins/gpsblam/src/org/openstreetmap/josm/plugins/gpsblam

Files:

• GPSBlamMode.java (modified) (6 diffs)
• GPSBlamPlugin.java (modified) (3 diffs)

applications/editors/josm/plugins/gpsblam/src/org/openstreetmap/josm/plugins/gpsblam/GPSBlamMode.java

@@ -24 +24 @@
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.actions.mapmode.MapMode;
-import org.openstreetmap.josm.gui.MapFrame;
 import org.openstreetmap.josm.gui.layer.LayerManager.LayerAddEvent;
 import org.openstreetmap.josm.gui.layer.LayerManager.LayerChangeListener;
@@ -33 +32 @@
 
     Point pointPressed;
-    MapFrame frame;
     private Point oldP2;
     int radius;
@@ -146 +144 @@
 
     private void xorDrawBox(Point p1, Point p2, int radius){
-        if (frame != null) {
-            Graphics2D g = (Graphics2D)Main.map.mapView.getGraphics();
+        if (Main.map != null) {
+            Graphics2D g = (Graphics2D) Main.map.mapView.getGraphics();
             g.setXORMode(Color.BLACK);
             g.setColor(Color.WHITE);
@@ -188 +186 @@
 
     private void paintBox(Point p2, int newRadius) {
-        if (frame != null) {
+        if (Main.map != null) {
             if (oldP2 != null) {
                 xorDrawBox(pointPressed, oldP2, radius); // clear old box
@@ -195 +193 @@
             oldP2 = p2;
         }
-    }
-
-    public void setFrame(MapFrame mapFrame) {
-        frame = mapFrame;
     }
 
@@ -215 +209 @@
         if (e.getRemovedLayer() instanceof GPSBlamLayer) {
             currentBlamLayer = null;
-            if(Main.map.mapMode instanceof GPSBlamMode)
+            if (Main.map.mapMode instanceof GPSBlamMode)
                 Main.map.selectSelectTool(false);
         }

applications/editors/josm/plugins/gpsblam/src/org/openstreetmap/josm/plugins/gpsblam/GPSBlamPlugin.java

@@ -4 +4 @@
 import static org.openstreetmap.josm.tools.I18n.tr;
 
-import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.gui.IconToggleButton;
 import org.openstreetmap.josm.gui.MapFrame;
@@ -17 +16 @@
 public class GPSBlamPlugin extends Plugin {
 
-    private final IconToggleButton btn;
-    private final GPSBlamMode mode;
-
     /**
      * Constructs a new {@code GPSBlamPlugin}.
@@ -26 +22 @@
     public GPSBlamPlugin(PluginInformation info) {
         super(info);
-        mode = new GPSBlamMode("gpsblam", tr("select gpx points and \"blam!\", find centre and direction of spread"));
-
-        btn = new IconToggleButton(mode);
-        btn.setVisible(true);
     }
 
     @Override
     public void mapFrameInitialized(MapFrame oldFrame, MapFrame newFrame) {
-        mode.setFrame(newFrame);
-        if (oldFrame == null && newFrame != null && Main.map != null) {
-            Main.map.addMapMode(btn);
+        if (oldFrame == null && newFrame != null) {
+            GPSBlamMode mode = new GPSBlamMode("gpsblam", tr("select gpx points and \"blam!\", find centre and direction of spread"));
+            IconToggleButton btn = new IconToggleButton(mode);
+            btn.setVisible(true);
+            newFrame.addMapMode(btn);
         }
     }