Changeset 33024 in osm

Timestamp:

2016-10-02T17:21:33+02:00 (8 years ago)

Author:

donvip

Message:

checkstyle

Location:

applications/editors/josm/plugins/dataimport

Files:

• .checkstyle (added)
• .project (modified) (1 diff)
• src/org/openstreetmap/josm/plugins/dataimport/DataImportPlugin.java (modified) (2 diffs)
• src/org/openstreetmap/josm/plugins/dataimport/io/TangoGPS.java (modified) (6 diffs)
• src/org/openstreetmap/josm/plugins/dataimport/io/Tcx.java (modified) (6 diffs)

applications/editors/josm/plugins/dataimport/.project

@@ -17 +17 @@
                         </arguments>
                 </buildCommand>
+                <buildCommand>
+                        <name>net.sf.eclipsecs.core.CheckstyleBuilder</name>
+                        <arguments>
+                        </arguments>
+                </buildCommand>
         </buildSpec>
         <natures>
                 <nature>org.eclipse.jdt.core.javanature</nature>
+                <nature>net.sf.eclipsecs.core.CheckstyleNature</nature>
         </natures>
 </projectDescription>

applications/editors/josm/plugins/dataimport/src/org/openstreetmap/josm/plugins/dataimport/DataImportPlugin.java

@@ -1 @@
-/**
- * This plugin leverages JOSM to import files.
- */
+// License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.plugins.dataimport;
 
@@ -21 +19 @@
      * @param info plugin information
      */
-    public DataImportPlugin(PluginInformation info) throws IOException{
+    public DataImportPlugin(PluginInformation info) throws IOException {
         super(info);
 

applications/editors/josm/plugins/dataimport/src/org/openstreetmap/josm/plugins/dataimport/io/TangoGPS.java

@@ -1 @@
-/**
- *
- */
+// License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.plugins.dataimport.io;
 
@@ -36 +34 @@
 
     public TangoGPS() {
-        super(new ExtensionFileFilter("log", "log",tr("TangoGPS Files (*.log)")));
+        super(new ExtensionFileFilter("log", "log", tr("TangoGPS Files (*.log)")));
     }
 
@@ -43 +41 @@
      * This function imports data from file and adds trackpoints to a layer.
      * Read a log file from TangoGPS. These are simple text files in the
-     * form: <lat>,<lon>,<elevation>,<speed>,<course>,<hdop>,<datetime>
+     * form: {@code <lat>,<lon>,<elevation>,<speed>,<course>,<hdop>,<datetime>}
      */
     @Override
@@ -76 +74 @@
             }
             failure = failure - imported;
-            if(imported > 0) {
+            if (imported > 0) {
                 GpxData data = new GpxData();
                 data.tracks.add(new ImmutableGpxTrack(Collections.singleton(currentTrackSeg), Collections.<String, Object>emptyMap()));
@@ -90 +88 @@
                 }
             }
-            showInfobox(imported,failure);
+            showInfobox(imported, failure);
         }
     }
@@ -104 +102 @@
     }
 
-    private void showInfobox(int success,int failure) {
+    private void showInfobox(int success, int failure) {
         String msg = tr("Coordinates imported: ") + success + " " + tr("Format errors: ") + failure + "\n";
         if (success > 0) {

applications/editors/josm/plugins/dataimport/src/org/openstreetmap/josm/plugins/dataimport/io/Tcx.java

@@ -47 +47 @@
  * The Garmin TCX Schema file can be downloaded from: <a
  * href="http://www.garmin.com/xmlschemas/TrainingCenterDatabasev2.xsd">http://www.garmin.com/xmlschemas/TrainingCenterDatabasev2.xsd</a>
- * The command used to generate the code is: <code>
- * xjc.bat -p org.openstreetmap.josm.io.tcx TrainingCenterDatabasev2.xsd -d <path to the src folder of JOSM>
- * </code>
+ * The command used to generate the code is:
+ * {@code xjc.bat -p org.openstreetmap.josm.io.tcx TrainingCenterDatabasev2.xsd -d <path to the src folder of JOSM>}
  * <p>
  * Note: if you get an exception that JAXB 2.1 is not supported on your system, you will have to add the jaxb-api.jar
  * to the endorsed directory (create it if necessary) of your JRE. Usually it is something like this:
- * \<program files>\Java\jre<java version>\lib\endorsed
+ * {@code \<program files>\Java\jre<java version>\lib\endorsed}
  *
- * @author adrian <as@nitegate.de>
+ * @author adrian &lt;as@nitegate.de&gt;
  *
  */
@@ -64 +63 @@
     private GpxData gpxData;
 
-
     public Tcx() {
-        super(new ExtensionFileFilter("tcx", "tcx",tr("TCX Files (*.tcx)")));
-    }
-
-    /**
-     * @param tcxFile
-     */
+        super(new ExtensionFileFilter("tcx", "tcx", tr("TCX Files (*.tcx)")));
+    }
+
     @Override
     public void importData(File tcxFile, ProgressMonitor progressMonitor) throws IOException {
@@ -80 +75 @@
         GpxLayer gpxLayer = new GpxLayer(gpxData, tcxFile.getName());
         Main.getLayerManager().addLayer(gpxLayer);
-        if (Main.pref.getBoolean("marker.makeautomarkers", true))
-        {
+        if (Main.pref.getBoolean("marker.makeautomarkers", true)) {
             MarkerLayer ml = new MarkerLayer(gpxData, tr("Markers from {0}", tcxFile.getName()), tcxFile, gpxLayer);
-            if (ml.data.size() > 0)
-            {
+            if (ml.data.size() > 0) {
                 Main.getLayerManager().addLayer(ml);
             }
@@ -98 +91 @@
                     .newInstance(TrainingCenterDatabaseT.class);
             Unmarshaller unmarshaller = jc.createUnmarshaller();
-            JAXBElement<TrainingCenterDatabaseT> element = (JAXBElement<TrainingCenterDatabaseT>)unmarshaller
+            JAXBElement<TrainingCenterDatabaseT> element = (JAXBElement<TrainingCenterDatabaseT>) unmarshaller
                     .unmarshal(tcxFile);
 
@@ -145 +138 @@
     }
 
-    /**
-     * @param tcd
-     */
     private void parseDataFromActivities(TrainingCenterDatabaseT tcd) {
         int lap = 0;
@@ -188 +178 @@
     }
 
-    /**
-     * @param tcd
-     */
     private void parseDataFromCourses(TrainingCenterDatabaseT tcd) {
         if ((tcd.getCourses() != null)