Changeset 32719 in osm for applications/editors/josm/plugins/wikipedia

Timestamp:

2016-07-26T17:19:58+02:00 (9 years ago)

Author:

simon04

Message:

JOSM/wikipedia: refactoring

Location:

applications/editors/josm/plugins/wikipedia/src/org/wikipedia

Files:

• WikipediaApp.java (modified) (1 diff)
• WikipediaToggleDialog.java (modified) (3 diffs)

applications/editors/josm/plugins/wikipedia/src/org/wikipedia/WikipediaApp.java ¶

@@ -146 +146 @@
     }
 
-    static void updateWIWOSMStatus(String wikipediaLang, Collection<WikipediaEntry> entries) {
+    static void updateWIWOSMStatus(String wikipediaLang, List<WikipediaEntry> entries) {
+        if (entries.size() > 20) {
+            partitionList(entries, 20).forEach(chunk -> updateWIWOSMStatus(wikipediaLang, chunk));
+            return;
+        }
         Map<String, Boolean> status = new HashMap<>();
         if (!entries.isEmpty()) {

applications/editors/josm/plugins/wikipedia/src/org/wikipedia/WikipediaToggleDialog.java ¶

@@ -35 +35 @@
 import org.openstreetmap.josm.data.osm.event.DatasetEventManager.FireMode;
 import org.openstreetmap.josm.data.osm.visitor.BoundingXYVisitor;
-import org.openstreetmap.josm.data.preferences.IntegerProperty;
 import org.openstreetmap.josm.data.preferences.StringProperty;
 import org.openstreetmap.josm.gui.SideButton;
@@ -168 +167 @@
     abstract class UpdateWikipediaArticlesSwingWorker extends SwingWorker<Void, WikipediaEntry> {
 
-        private final IntegerProperty wikipediaStatusUpdateChunkSize = new IntegerProperty("wikipedia.statusupdate.chunk-size", 20);
-
         abstract List<WikipediaEntry> getEntries();
 
@@ -177 +174 @@
             Collections.sort(entries);
             publish(entries.toArray(new WikipediaEntry[entries.size()]));
-            for (List<WikipediaEntry> chunk : WikipediaApp.partitionList(entries, wikipediaStatusUpdateChunkSize.get())) {
-                WikipediaApp.updateWIWOSMStatus(chunk.get(0).wikipediaLang, chunk);
+            if (!entries.isEmpty()) {
+                WikipediaApp.updateWIWOSMStatus(entries.get(0).wikipediaLang, entries);
             }
             return null;