Changeset 32567 in osm for applications/editors/josm

Timestamp:

2016-07-05T00:28:27+02:00 (8 years ago)

Author:

darya

Message:

removed old classes, updated unit tests, added AddStopPositionAction

Location:

applications/editors/josm/plugins/pt_assistant

Files:

• images/next.svg (added)
• src/org/openstreetmap/josm/plugins/pt_assistant/PTAssistantPlugin.java (modified) (3 diffs)
• src/org/openstreetmap/josm/plugins/pt_assistant/actions/AddStopPositionAction.java (added)
• src/org/openstreetmap/josm/plugins/pt_assistant/gui/PTAssistantLayer.java (modified) (2 diffs)
• src/org/openstreetmap/josm/plugins/pt_assistant/utils/RouteUtils.java (modified) (2 diffs)
• src/org/openstreetmap/josm/plugins/pt_assistant/validation/PTAssistantValidatorTest.java (added)
• src/org/openstreetmap/josm/plugins/pt_assistant/validation/RouteChecker.java (modified) (2 diffs)
• src/org/openstreetmap/josm/plugins/pt_assistant/validation/SegmentChecker.java (modified) (4 diffs)
• src/org/openstreetmap/josm/plugins/pt_assistant/validation/WayChecker.java (modified) (6 diffs)
• test/unit/org/openstreetmap/josm/plugins/pt_assistant/data/RouteRepresentationTest.java (modified) (9 diffs)
• test/unit/org/openstreetmap/josm/plugins/pt_assistant/validation/DirecionTestTest.java (modified) (4 diffs)
• test/unit/org/openstreetmap/josm/plugins/pt_assistant/validation/PlatformAsWayTest.java (modified) (2 diffs)
• test/unit/org/openstreetmap/josm/plugins/pt_assistant/validation/RoadTypeTestTest.java (modified) (2 diffs)
• test/unit/org/openstreetmap/josm/plugins/pt_assistant/validation/SortingTestTest.java (added)

applications/editors/josm/plugins/pt_assistant/src/org/openstreetmap/josm/plugins/pt_assistant/PTAssistantPlugin.java

@@ -2 +2 @@
 package org.openstreetmap.josm.plugins.pt_assistant;
 
+import javax.swing.JMenuItem;
+
+import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.data.validation.OsmValidator;
+import org.openstreetmap.josm.gui.MainMenu;
+import org.openstreetmap.josm.gui.MapFrame;
 import org.openstreetmap.josm.plugins.Plugin;
 import org.openstreetmap.josm.plugins.PluginInformation;
-import org.openstreetmap.josm.plugins.pt_assistant.validation.PTAssitantValidatorTest;
+import org.openstreetmap.josm.plugins.pt_assistant.actions.AddStopPositionAction;
+import org.openstreetmap.josm.plugins.pt_assistant.validation.PTAssistantValidatorTest;
+import org.openstreetmap.josm.tools.ImageProvider;
 
 /**
@@ -14 +21 @@
  */
 public class PTAssistantPlugin extends Plugin {
-        
+
+        private JMenuItem addStopPositionMenu;
+
         /**
          * Main constructor.
@@ -25 +34 @@
                 super(info);
 
-//              OsmValidator.addTest(PlatformsFirstTest.class);
-//              OsmValidator.addTest(RoadTypeTest.class);
-//              OsmValidator.addTest(DirectionTest.class);
-//              OsmValidator.addTest(GapTest.class);
+                OsmValidator.addTest(PTAssistantValidatorTest.class);
                 
-                OsmValidator.addTest(PTAssitantValidatorTest.class);
-                
+                AddStopPositionAction addStopPositionAction = new AddStopPositionAction();
+                addStopPositionMenu = MainMenu.add(Main.main.menu.toolsMenu, addStopPositionAction, false);
 
         }
+
+        /**
+         * Called when the JOSM map frame is created or destroyed.
+         */
+        @Override
+        public void mapFrameInitialized(MapFrame oldFrame, MapFrame newFrame) {
+                if (oldFrame == null && newFrame != null) {
+                        addStopPositionMenu.setEnabled(true);
+                } else if (oldFrame != null && newFrame == null) {
+                        addStopPositionMenu.setEnabled(false);
+                }
+        }
         
-
-
-
+        /**
+         * Returns a ImageProvider for the given string or null if in headless mode.
+         *
+         * @param s
+         *            The name of the file where the picture is.
+         * @return A ImageProvider object for the given string or null if in
+         *         headless mode.
+         */
+        public static ImageProvider getProvider(String s) {
+                if (Main.main == null) {
+                        return null;
+                }
+                return new ImageProvider(s);
+        }
 
 }

applications/editors/josm/plugins/pt_assistant/src/org/openstreetmap/josm/plugins/pt_assistant/gui/PTAssistantLayer.java

@@ -176 +176 @@
                                         }
 
-                                        Main.map.repaint();
+                                        Main.map.mapView.repaint();
                                 }
 
@@ -200 +200 @@
 
                         this.primitives.clear();
-                        Main.map.repaint();
+                        Main.map.mapView.repaint();
                 }
 

applications/editors/josm/plugins/pt_assistant/src/org/openstreetmap/josm/plugins/pt_assistant/utils/RouteUtils.java

@@ -4 +4 @@
 import org.openstreetmap.josm.data.osm.Relation;
 import org.openstreetmap.josm.data.osm.RelationMember;
-import org.openstreetmap.josm.data.osm.Way;
 
 /**
@@ -114 +113 @@
         }
 
-        /**
-         * Checks if the type of the way is suitable for buses to go on it. The
-         * direction of the way (i.e. one-way roads) is irrelevant for this test.
-         * 
-         * TODO: this test is duplicated in WayChecker, remove it here when the old
-         * implementation is not needed anymore.
-         * 
-         * @deprecated
-         * 
-         * @param way
-         *            to be checked
-         * @return true if the way is suitable for buses, false otherwise.
-         */
-        public static boolean isWaySuitableForBuses(Way way) {
-                if (way.hasTag("highway", "motorway") || way.hasTag("highway", "trunk") || way.hasTag("highway", "primary")
-                                || way.hasTag("highway", "secondary") || way.hasTag("highway", "tertiary")
-                                || way.hasTag("highway", "unclassified") || way.hasTag("highway", "road")
-                                || way.hasTag("highway", "residential") || way.hasTag("highway", "service")
-                                || way.hasTag("highway", "motorway_link") || way.hasTag("highway", "trunk_link")
-                                || way.hasTag("highway", "primary_link") || way.hasTag("highway", "secondary_link")
-                                || way.hasTag("highway", "tertiary_link") || way.hasTag("highway", "living_street")
-                                || way.hasTag("highway", "bus_guideway") || way.hasTag("highway", "road")
-                                || way.hasTag("cycleway", "share_busway") || way.hasTag("cycleway", "shared_lane")) {
-                        return true;
-                }
-
-                if (way.hasTag("highway", "pedestrian") && (way.hasTag("bus", "yes") || way.hasTag("psv", "yes")
-                                || way.hasTag("bus", "designated") || way.hasTag("psv", "designated"))) {
-                        return true;
-                }
-
-                return false;
-        }
-
-        public static boolean hasIncompleteMembers(Relation r) {
-                if (r == null) {
-                        return true;
-                }
-                for (RelationMember rm : r.getMembers()) {
-                        if ((rm.isNode() && rm.getNode().isIncomplete()) || (rm.isWay() && rm.getWay().isIncomplete())
-                                        || (rm.isRelation() && rm.getRelation().isIncomplete())) {
-                                return true;
-                        }
-                }
-
-                return false;
-        }
-
 }

applications/editors/josm/plugins/pt_assistant/src/org/openstreetmap/josm/plugins/pt_assistant/validation/RouteChecker.java

@@ -65 +65 @@
                                 TestError e = new TestError(this.test, Severity.WARNING,
                                                 tr("PT: Route contains a gap that can be fixed by sorting"),
-                                                PTAssitantValidatorTest.ERROR_CODE_SORTING, relation);
+                                                PTAssistantValidatorTest.ERROR_CODE_SORTING, relation);
                                 this.errors.add(e);
 
@@ -112 +112 @@
         
         protected static Command fixSortingError(TestError testError) {
-                if (testError.getCode() != PTAssitantValidatorTest.ERROR_CODE_SORTING) {
+                if (testError.getCode() != PTAssistantValidatorTest.ERROR_CODE_SORTING) {
                         return null;
                 }

applications/editors/josm/plugins/pt_assistant/src/org/openstreetmap/josm/plugins/pt_assistant/validation/SegmentChecker.java

@@ -52 +52 @@
                         highlighted.add(rm.getMember());
                         TestError e = new TestError(this.test, Severity.WARNING, tr("PT: Relation member roles do not match tags"),
-                                        PTAssitantValidatorTest.ERROR_CODE_RELAITON_MEMBER_ROLES, primitives, highlighted);
+                                        PTAssistantValidatorTest.ERROR_CODE_RELAITON_MEMBER_ROLES, primitives, highlighted);
                         this.errors.add(e);
                 }
@@ -112 +112 @@
                                 TestError e = new TestError(this.test, Severity.WARNING,
                                                 tr("PT: Route should start and end with a stop_position"),
-                                                PTAssitantValidatorTest.ERROR_CODE_END_STOP, primitives, highlighted);
+                                                PTAssistantValidatorTest.ERROR_CODE_END_STOP, primitives, highlighted);
                                 this.errors.add(e);
                                 return;
@@ -130 +130 @@
 
                                 TestError e = new TestError(this.test, Severity.WARNING, tr("PT: First or last way needs to be split"),
-                                                PTAssitantValidatorTest.ERROR_CODE_SPLIT_WAY, primitives, highlighted);
+                                                PTAssistantValidatorTest.ERROR_CODE_SPLIT_WAY, primitives, highlighted);
                                 this.errors.add(e);
                         }
@@ -146 +146 @@
                                 highlighted.add(endStop.getStopPosition());
                                 TestError e = new TestError(this.test, Severity.WARNING, tr("PT: First or last way needs to be split"),
-                                                PTAssitantValidatorTest.ERROR_CODE_SPLIT_WAY, primitives, highlighted);
+                                                PTAssistantValidatorTest.ERROR_CODE_SPLIT_WAY, primitives, highlighted);
                                 this.errors.add(e);
                         }

applications/editors/josm/plugins/pt_assistant/src/org/openstreetmap/josm/plugins/pt_assistant/validation/WayChecker.java

@@ -121 +121 @@
                                         TestError e = new TestError(this.test, Severity.WARNING,
                                                         tr("PT: Route type does not match the type of the road it passes on"),
-                                                        PTAssitantValidatorTest.ERROR_CODE_ROAD_TYPE, primitives, highlighted);
+                                                        PTAssistantValidatorTest.ERROR_CODE_ROAD_TYPE, primitives, highlighted);
                                         errors.add(e);
 
@@ -132 +132 @@
                                         highlighted.add(way);
                                         TestError e = new TestError(this.test, Severity.WARNING, tr("PT: Road is under construction"),
-                                                        PTAssitantValidatorTest.ERROR_CODE_CONSTRUCTION, primitives, highlighted);
+                                                        PTAssistantValidatorTest.ERROR_CODE_CONSTRUCTION, primitives, highlighted);
                                         errors.add(e);
                                 }
@@ -180 +180 @@
                                         TestError e = new TestError(this.test, Severity.WARNING,
                                                         tr("PT: Route passes a oneway road in the wrong direction"),
-                                                        PTAssitantValidatorTest.ERROR_CODE_DIRECTION, primitives, highlighted);
+                                                        PTAssistantValidatorTest.ERROR_CODE_DIRECTION, primitives, highlighted);
                                         this.errors.add(e);
                                         return;
@@ -221 +221 @@
         protected static Command fixErrorByRemovingWay(TestError testError) {
 
-                if (testError.getCode() != PTAssitantValidatorTest.ERROR_CODE_ROAD_TYPE
-                                && testError.getCode() != PTAssitantValidatorTest.ERROR_CODE_DIRECTION) {
+                if (testError.getCode() != PTAssistantValidatorTest.ERROR_CODE_ROAD_TYPE
+                                && testError.getCode() != PTAssistantValidatorTest.ERROR_CODE_DIRECTION) {
                         return null;
                 }
@@ -279 +279 @@
         protected static Command fixErrorByZooming(TestError testError) {
 
-                if (testError.getCode() != PTAssitantValidatorTest.ERROR_CODE_DIRECTION) {
+                if (testError.getCode() != PTAssistantValidatorTest.ERROR_CODE_DIRECTION) {
                         return null;
                 }
@@ -337 +337 @@
                 GenericRelationEditor editor = new GenericRelationEditor(layer, r, r.getMembersFor(primitives));
                 RelationDialogManager.getRelationDialogManager().register(layer, r, editor);
-                
-                
                 editor.setVisible(true);
-//              editor.requestFocus();
-//              editor.requestFocusInWindow();
-                
-//              editor.firePropertyChange("focusedWindow", editor, editor);
-//              editor.setRelation(r);
+
 
         }

applications/editors/josm/plugins/pt_assistant/test/unit/org/openstreetmap/josm/plugins/pt_assistant/data/RouteRepresentationTest.java

@@ -2 +2 @@
 
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
 
 import java.util.ArrayList;
@@ -31 +30 @@
          * stop2(platform, Way)
          * way2 (Way)
-         * stop3 (stop_area)
+         * stop3 (platform)
          * way3 (Relation that consists of Ways only)
          * stop4 (stop_position)
@@ -45 +44 @@
         Node n1 = new Node(); 
         n1.put("name", "Stop1");
+        n1.put("public_transport", "stop_position");
         RelationMember rm1 = new RelationMember("stop", n1);
         members.add(rm1);
@@ -52 +52 @@
         RelationMember rm2 = new RelationMember("platform", w1);
         members.add(rm2);
-        Relation r1 = new Relation();
-        r1.put("name", "Stop3");
-        RelationMember rm3 = new RelationMember("stop_area", r1);
+        Node n2 = new Node();
+        n2.put("name", "Stop3");
+        n2.put("public_transport", "platform");
+        RelationMember rm3 = new RelationMember("platform", n2);
         members.add(rm3);
-        Node n2 = new Node();
-        n2.put("name", "Stop4");
-        RelationMember rm4 = new RelationMember("stop", n2);
-        members.add(rm4);
         Node n3 = new Node();
         n3.put("name", "Stop4");
-        RelationMember rm5 = new RelationMember("platform", n3);
+        n3.put("public_transport", "stop_position");
+        RelationMember rm4 = new RelationMember("stop", n3);
+        members.add(rm4);
+        Node n4 = new Node();
+        n4.put("name", "Stop4");
+        n4.put("public_transport", "platform");
+        RelationMember rm5 = new RelationMember("platform", n4);
         members.add(rm5);
-        Relation r2 = new Relation();
-        r2.put("name", "Stop5");
-        r2.put("highway", "platform_exit_only");
-        RelationMember rm6 = new RelationMember("platform_exit_only", r2);
+        Node n5 = new Node();
+        n5.put("name", "Stop5");
+        n5.put("highway", "platform");
+        RelationMember rm6 = new RelationMember("platform_exit_only", n5);
         members.add(rm6);
                 
@@ -90 +93 @@
         members.add(rm10);
         
-
-        
         Relation route = new Relation();
         route.setMembers(members);
@@ -112 +113 @@
         Node n1 = new Node(); 
         n1.put("name", "Stop1");
+        n1.put("public_transport", "stop_position");
         RelationMember rm1 = new RelationMember("stop", n1);
         members.add(rm1);
@@ -119 +121 @@
         RelationMember rm2 = new RelationMember("platform", w1);
         members.add(rm2);
-        Relation r1 = new Relation();
-        r1.put("name", "Stop3");
-        RelationMember rm3 = new RelationMember("stop_area", r1);
+        Node n2 = new Node();
+        n2.put("name", "Stop3");
+        n2.put("public_transport", "platform");
+        RelationMember rm3 = new RelationMember("platform", n2);
         members.add(rm3);
-        Node n2 = new Node();
-        n2.put("name", "Stop4");
-        RelationMember rm4 = new RelationMember("stop", n2);
-        members.add(rm4);
         Node n3 = new Node();
         n3.put("name", "Stop4");
-        RelationMember rm5 = new RelationMember("platform", n3);
+        n3.put("public_transport", "stop_position");
+        RelationMember rm4 = new RelationMember("stop", n3);
+        members.add(rm4);
+        Node n4 = new Node();
+        n4.put("name", "Stop4");
+        n4.put("public_transport", "platform");
+        RelationMember rm5 = new RelationMember("platform", n4);
         members.add(rm5);
-        Relation r2 = new Relation();
-        r2.put("name", "Stop5");
-        r2.put("highway", "platform_exit_only");
-        RelationMember rm6 = new RelationMember("platform_exit_only", r2);
+        Node n5 = new Node();
+        n5.put("name", "Stop5");
+        n5.put("highway", "platform");
+        RelationMember rm6 = new RelationMember("platform_exit_only", n5);
         members.add(rm6);
                 
@@ -146 +151 @@
         Relation r3 = new Relation(); // nested relation
         Way w4 = new Way();
-        Node wrongNode = new Node(); // CHANGED COMPARED TO PREVIOUS TEST
+        Node wrongNode = new Node();
         Way w6 = new Way();
         r3.addMember(new RelationMember("", w4));
-        r3.addMember(new RelationMember("platform", wrongNode));
+        r3.addMember(new RelationMember("", wrongNode));
         r3.addMember(new RelationMember("", w6));
         RelationMember rm9 = new RelationMember("", r3);
@@ -161 +166 @@
         route.setMembers(members);
         
-        boolean thrown = false;
-        String message = "";
-        try {
-            /*PTRouteDataManager manager =*/ new PTRouteDataManager(route);
-        } catch(IllegalArgumentException e) {
-            thrown = true;
-            message = e.getMessage();
-        }
+        PTRouteDataManager manager = new PTRouteDataManager(route);
         
-        assertTrue(thrown);
-        assertEquals(message, "A route relation member of OsmPrimitiveType.RELATION can only have ways as members");
+        assertEquals(manager.getFailedMembers().size(), 1);
+        assertEquals(manager.getPTStopCount(), 5);
+        assertEquals(manager.getPTWayCount(), 3);
         
     }
     
-    
-    @Test
-    public void multipleStopElementTest() {
-        
-        // Same as correctRouteTest(), but 
-        
-        ArrayList<RelationMember> members = new ArrayList<>();
-        
-        // Create stops:
-        Node n1 = new Node(); 
-        n1.put("name", "Stop1");
-        RelationMember rm1 = new RelationMember("stop", n1);
-        members.add(rm1);
-        Way w1 = new Way();
-        w1.put("name", "Stop2");
-        w1.put("highway", "platform");
-        RelationMember rm2 = new RelationMember("platform", w1);
-        members.add(rm2);
-        Relation r1 = new Relation();
-        r1.put("name", "Stop3");
-        RelationMember rm3 = new RelationMember("stop_area", r1);
-        members.add(rm3);
-        Node n2 = new Node();
-        n2.put("name", "Stop4");
-        RelationMember rm4 = new RelationMember("stop", n2);
-        members.add(rm4);
-        Node n3 = new Node();
-        n3.put("name", "Stop4");
-        RelationMember rm5 = new RelationMember("platform", n3);
-        members.add(rm5);
-        Relation r2 = new Relation();
-        r2.put("name", "Stop5");
-        r2.put("highway", "platform_exit_only");
-        RelationMember rm6 = new RelationMember("platform_exit_only", r2);
-        members.add(rm6);
-                
-        // Create ways:
-        Way w2 = new Way();
-        RelationMember rm7 = new RelationMember("", w2);
-        members.add(rm7);
-        Way w3 = new Way();
-        RelationMember rm8 = new RelationMember("", w3);
-        members.add(rm8);
-        Relation r3 = new Relation(); // nested relation
-        Way w4 = new Way();
-        Way w5 = new Way();
-        Way w6 = new Way();
-        r3.addMember(new RelationMember("", w4));
-        r3.addMember(new RelationMember("", w5));
-        r3.addMember(new RelationMember("", w6));
-        RelationMember rm9 = new RelationMember("", r3);
-        members.add(rm9);
-        Way w7 = new Way();
-        RelationMember rm10 = new RelationMember("", w7);
-        members.add(rm10);
-        
-
-        
-        Relation route = new Relation();
-        route.setMembers(members);
-        
-        PTRouteDataManager manager = new PTRouteDataManager(route);
-    
-        assertEquals(manager.getPTStopCount(), 5);
-        assertEquals(manager.getPTWayCount(), 4);
-        
-    }
-    
-
 }

applications/editors/josm/plugins/pt_assistant/test/unit/org/openstreetmap/josm/plugins/pt_assistant/validation/DirecionTestTest.java

@@ -5 +5 @@
 
 import java.io.File;
+import java.util.ArrayList;
 import java.util.List;
 
@@ -19 +20 @@
     @Test
     public void test() {
-        // this file has:
-        // Way 
-        
         
         File file = new File(AbstractTest.PATH_TO_ROUNDABOUT_ONEWAY);
         DataSet ds = ImportUtils.importOsmFile(file, "testLayer");
+        
+        PTAssitantValidatorTest test = new PTAssitantValidatorTest();
         
         Relation route = null;
@@ -35 +35 @@
         assertEquals(route.getMembersCount(), 213);
                 
-        DirectionTest directionTest = new DirectionTest();
+        List<TestError> errors = new ArrayList<>();
+        
         for (Relation r: ds.getRelations()) {
-            directionTest.visit(r);
+                WayChecker wayChecker = new WayChecker(r, test);
+                wayChecker.performDirectionTest();
+                errors.addAll(wayChecker.getErrors());
         }
         
-        List<TestError> errors = directionTest.getErrors();
         assertEquals(errors.size(), 1);
         int onewayErrorCaught = 0;
         for (TestError e: errors ) {
-            if (e.getCode() == DirectionTest.ERROR_CODE_DIRECTION) {
+            if (e.getCode() == PTAssitantValidatorTest.ERROR_CODE_DIRECTION) {
                 onewayErrorCaught++;
             }
@@ -55 +57 @@
         boolean detectedErrorsAreCorrect = true;
         for (TestError e: errors) {
-            if (e.getCode() == DirectionTest.ERROR_CODE_DIRECTION) {
+            if (e.getCode() == PTAssitantValidatorTest.ERROR_CODE_DIRECTION) {
                 @SuppressWarnings("unchecked")
                 List<OsmPrimitive> highlighted = (List<OsmPrimitive>) e.getHighlighted();

applications/editors/josm/plugins/pt_assistant/test/unit/org/openstreetmap/josm/plugins/pt_assistant/validation/PlatformAsWayTest.java

@@ -4 +4 @@
 
 import java.io.File;
+import java.util.ArrayList;
 import java.util.List;
 
@@ -20 +21 @@
         DataSet ds = ImportUtils.importOsmFile(file, "testLayer");
         
-        GapTest gapTest = new GapTest();
+        PTAssitantValidatorTest test = new PTAssitantValidatorTest();
+        
+        List<TestError> errors = new ArrayList<>();
+        
         for (Relation r: ds.getRelations()) {
-            gapTest.visit(r);
+                WayChecker wayChecker = new WayChecker(r, test);
+                wayChecker.performDirectionTest();
+                wayChecker.performRoadTypeTest();
+                errors.addAll(wayChecker.getErrors());
+                RouteChecker routeChecker = new RouteChecker(r, test);
+                routeChecker.performSortingTest();
+                errors.addAll(routeChecker.getErrors());
         }
-        
-        List<TestError> errors = gapTest.getErrors();
         
         assertEquals(errors.size(), 0);

applications/editors/josm/plugins/pt_assistant/test/unit/org/openstreetmap/josm/plugins/pt_assistant/validation/RoadTypeTestTest.java

@@ -5 +5 @@
 
 import java.io.File;
+import java.util.ArrayList;
 import java.util.List;
 
@@ -24 +25 @@
         DataSet ds = ImportUtils.importOsmFile(file, "testLayer");
         
-        RoadTypeTest roadTypeTest = new RoadTypeTest();
+        PTAssitantValidatorTest test = new PTAssitantValidatorTest();
+        List<TestError> errors = new ArrayList<>();
+        
         for (Relation r: ds.getRelations()) {
-            roadTypeTest.visit(r);
+                WayChecker wayChecker = new WayChecker(r, test);
+                wayChecker.performRoadTypeTest();
+                errors.addAll(wayChecker.getErrors());
         }
         
-        List<TestError> errors = roadTypeTest.getErrors();
         assertEquals(errors.size(), 2);
         
         for (TestError e: errors) {
-            assertEquals(e.getCode(), RoadTypeTest.ERROR_CODE_ROAD_TYPE);
+            assertEquals(e.getCode(), PTAssitantValidatorTest.ERROR_CODE_ROAD_TYPE);
             @SuppressWarnings("unchecked")
             List<OsmPrimitive> highlighted = (List<OsmPrimitive>) e.getHighlighted();