Changeset 3238 in josm for trunk/src/org

Timestamp:

2010-05-13T09:19:55+02:00 (15 years ago)

Author:

jttt

Message:

Fix #4633 All big internal Help Pages opens in middle page

File:

• trunk/src/org/openstreetmap/josm/gui/help/HelpBrowser.java (modified) (10 diffs)

trunk/src/org/openstreetmap/josm/gui/help/HelpBrowser.java

@@ -14 +14 @@
 import java.awt.event.WindowEvent;
 import java.io.BufferedReader;
-import java.io.IOException;
 import java.io.InputStreamReader;
+import java.io.StringReader;
 import java.util.Locale;
 import java.util.Observable;
@@ -28 +28 @@
 import javax.swing.JOptionPane;
 import javax.swing.JPanel;
-import javax.swing.JScrollBar;
 import javax.swing.JScrollPane;
 import javax.swing.JSeparator;
@@ -102 +101 @@
     /** the help browser */
     private JEditorPane help;
-    private JScrollPane spHelp;
 
     /** the help browser history */
@@ -166 +164 @@
         setContentPane(p);
 
-        p.add(spHelp = new JScrollPane(help), BorderLayout.CENTER);
+        p.add(new JScrollPane(help), BorderLayout.CENTER);
 
         addWindowListener(new WindowAdapter(){
@@ -205 +203 @@
         reader = new HelpContentReader(HelpUtil.getWikiBaseUrl());
         build();
+    }
+
+    protected void loadTopic(String content) {
+        Document document = help.getEditorKit().createDefaultDocument();
+        try {
+            help.getEditorKit().read(new StringReader(content), document, 0);
+        } catch (Exception e) {
+            e.printStackTrace();
+        }
+        help.setDocument(document);
     }
 
@@ -235 +243 @@
                 getHelpTopicEditUrl(buildAbsoluteHelpTopic(relativeHelpTopic, Locale.ENGLISH))
         );
-        help.setText(message);
+        loadTopic(message);
     }
 
@@ -253 +261 @@
                 e.toString()
         );
-        help.setText(message);
-    }
-
-    protected void scrollToTop() {
-        JScrollBar sb = spHelp.getVerticalScrollBar();
-        sb.setValue(sb.getMinimum());
+        loadTopic(message);
     }
 
@@ -293 +296 @@
             return;
         }
-        help.setText(content);
+        loadTopic(content);
         history.setCurrentUrl(url);
         this.url = url;
-        scrollToTop();
     }
 
@@ -319 +321 @@
             return;
         }
-        help.setText(content);
+        loadTopic(content);
         history.setCurrentUrl(url);
         this.url = url;
-        scrollToTop();
     }
 
@@ -345 +346 @@
                 this.url = url;
                 String content = reader.fetchHelpTopicContent(url, false);
-                help.setText(content);
+                loadTopic(content);
                 history.setCurrentUrl(url);
                 this.url = url;
-                scrollToTop();
             } catch(Exception e) {
                 HelpAwareOptionPane.showOptionDialog(