Changeset 31611 in osm for applications

Timestamp:

2015-10-11T23:52:47+02:00 (9 years ago)

Author:

wiktorn

Message:

Fix missing tiles in cache, when tiles list is short (ex. low zoom level)

When there is small number of tiles that are fetched from MemoryTileCache
(smaller than size of the cache) - then they could be put multiple times in LRU
list although they were present only once in hash.

Now only move elements, when they are not present in hash.

File:

• applications/viewer/jmapviewer/src/org/openstreetmap/gui/jmapviewer/MemoryTileCache.java (modified) (1 diff)

applications/viewer/jmapviewer/src/org/openstreetmap/gui/jmapviewer/MemoryTileCache.java

@@ -52 +52 @@
     public synchronized void addTile(Tile tile) {
         CacheEntry entry = createCacheEntry(tile);
-        hash.put(tile.getKey(), entry);
-        lruTiles.addFirst(entry);
-        if (hash.size() > cacheSize || lruTiles.getElementCount() > cacheSize) {
-            removeOldEntries();
+        if (hash.put(tile.getKey(), entry) == null) {
+            // only if hash hadn't had the element, add it to LRU
+            lruTiles.addFirst(entry);
+            if (hash.size() > cacheSize || lruTiles.getElementCount() > cacheSize) {
+                removeOldEntries();
+            }
         }
     }