Changeset 31450 in osm for applications/editors/josm/plugins/mapillary

Timestamp:

2015-08-05T11:45:39+02:00 (9 years ago)

Author:

nokutu

Message:

Remove getInstance method in MapillaryData class.

Location:

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary

Files:

• MapillaryData.java (modified) (4 diffs)
• MapillaryLayer.java (modified) (2 diffs)
• actions/MapillaryExportAction.java (modified) (3 diffs)
• actions/MapillaryImportAction.java (modified) (4 diffs)
• actions/MapillaryImportIntoSequenceAction.java (modified) (2 diffs)
• actions/MapillaryUploadAction.java (modified) (3 diffs)
• actions/MapillaryZoomAction.java (modified) (3 diffs)
• gui/MapillaryExportDialog.java (modified) (3 diffs)
• gui/MapillaryFilterDialog.java (modified) (7 diffs)
• gui/MapillaryMainDialog.java (modified) (6 diffs)
• gui/MapillaryUploadDialog.java (modified) (2 diffs)
• mode/AbstractMode.java (modified) (1 diff)

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/MapillaryData.java

@@ -18 +18 @@
 public class MapillaryData {
 
-  /** Unique instance of the class */
-  public volatile static MapillaryData INSTANCE;
-
   private final List<MapillaryAbstractImage> images;
   private MapillaryAbstractImage selectedImage;
@@ -32 +29 @@
    * Main constructor.
    */
-  private MapillaryData() {
+  protected MapillaryData() {
     this.images = new CopyOnWriteArrayList<>();
     this.multiSelectedImages = new ArrayList<>();
@@ -38 +35 @@
 
     addListener(MapillaryPlugin.walkAction);
-  }
-
-  /**
-   * Returns the unique instance of the class.
-   *
-   * @return The unique instance of the class.
-   */
-  public static MapillaryData getInstance() {
-    if (INSTANCE == null) {
-      INSTANCE = new MapillaryData();
-    }
-    return INSTANCE;
-  }
-
-  /**
-   * Destroys the unique instance.
-   */
-  public static void clearInstance() {
-    INSTANCE = null;
   }
 
@@ -317 +295 @@
     }
     if (zoom)
-      Main.map.mapView.zoomTo(MapillaryData.getInstance().getSelectedImage()
-          .getLatLon());
+      Main.map.mapView.zoomTo(getSelectedImage().getLatLon());
     if (Main.main != null)
       Main.map.mapView.repaint();

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/MapillaryLayer.java

@@ -99 +99 @@
   private MapillaryLayer() {
     super(tr("Mapillary Images"));
-    this.data = MapillaryData.getInstance();
+    this.data = new MapillaryData();
     this.bounds = new CopyOnWriteArrayList<>();
     init();
@@ -190 +190 @@
     if (Main.map.mapView.getEditLayer() != null)
       Main.map.mapView.getEditLayer().data.removeDataSetListener(this);
-    MapillaryData.clearInstance();
     clearInstance();
     super.destroy();

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryExportAction.java

@@ -18 +18 @@
 import org.openstreetmap.josm.actions.JosmAction;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryAbstractImage;
-import org.openstreetmap.josm.plugins.mapillary.MapillaryData;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryImage;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryImportedImage;
+import org.openstreetmap.josm.plugins.mapillary.MapillaryLayer;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryPlugin;
 import org.openstreetmap.josm.plugins.mapillary.downloads.MapillaryExportManager;
@@ -71 +71 @@
         && this.dialog.chooser != null) {
       if (this.dialog.group.isSelected(this.dialog.all.getModel())) {
-        export(MapillaryData.getInstance().getImages());
+        export(MapillaryLayer.getInstance().data.getImages());
       } else if (this.dialog.group.isSelected(this.dialog.sequence.getModel())) {
         ArrayList<MapillaryAbstractImage> images = new ArrayList<>();
-        for (MapillaryAbstractImage image : MapillaryData.getInstance()
+        for (MapillaryAbstractImage image : MapillaryLayer.getInstance().data
             .getMultiSelectedImages())
           if (image instanceof MapillaryImage) {
@@ -83 +83 @@
         export(images);
       } else if (this.dialog.group.isSelected(this.dialog.selected.getModel())) {
-        export(MapillaryData.getInstance().getMultiSelectedImages());
+        export(MapillaryLayer.getInstance().data.getMultiSelectedImages());
       }
       // This option ignores the selected directory.
     } else if (this.dialog.group.isSelected(this.dialog.rewrite.getModel())) {
       ArrayList<MapillaryImportedImage> images = new ArrayList<>();
-      for (MapillaryAbstractImage image : MapillaryData.getInstance()
+      for (MapillaryAbstractImage image : MapillaryLayer.getInstance().data
           .getImages())
         if (image instanceof MapillaryImportedImage) {

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryImportAction.java

@@ -22 +22 @@
 import org.openstreetmap.josm.actions.JosmAction;
 import org.openstreetmap.josm.data.coor.LatLon;
-import org.openstreetmap.josm.plugins.mapillary.MapillaryData;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryImportedImage;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryLayer;
@@ -85 +84 @@
             try {
               if (extension.equals("jpg") || extension.equals("jpeg"))
-                MapillaryData.getInstance().add(readJPG(file.listFiles()[j]));
+                MapillaryLayer.getInstance().data.add(readJPG(file.listFiles()[j]));
 
               else if (extension.equals("png"))
-                MapillaryData.getInstance().add(readPNG(file.listFiles()[j]));
+                MapillaryLayer.getInstance().data.add(readPNG(file.listFiles()[j]));
             } catch (ImageReadException | IOException | NullPointerException e1) {
               Main.error(e1);
@@ -99 +98 @@
                   .equals(".jpeg")) {
             try {
-              MapillaryData.getInstance().add(readJPG(file));
+              MapillaryLayer.getInstance().data.add(readJPG(file));
             } catch (ImageReadException ex) {
               Main.error(ex);
@@ -107 +106 @@
           } else if (file.getPath().substring(file.getPath().length() - 4)
               .equals(".png")) {
-            MapillaryData.getInstance().add(readPNG(file));
+            MapillaryLayer.getInstance().data.add(readPNG(file));
           }
         }

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryImportIntoSequenceAction.java

@@ -25 +25 @@
 import org.openstreetmap.josm.actions.JosmAction;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryAbstractImage;
-import org.openstreetmap.josm.plugins.mapillary.MapillaryData;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryImportedImage;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryLayer;
@@ -162 +161 @@
       MapillaryImportedImage image = new MapillaryImportedImage(latValue,
           lonValue, caValue, file, datetimeOriginal.getStringValue());
-      MapillaryData.getInstance().add(image);
+      MapillaryLayer.getInstance().data.add(image);
       image.getCapturedAt();
 

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryUploadAction.java

@@ -13 +13 @@
 import org.openstreetmap.josm.actions.JosmAction;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryAbstractImage;
-import org.openstreetmap.josm.plugins.mapillary.MapillaryData;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryDataListener;
+import org.openstreetmap.josm.plugins.mapillary.MapillaryLayer;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryPlugin;
 import org.openstreetmap.josm.plugins.mapillary.gui.MapillaryUploadDialog;
@@ -38 +38 @@
             Shortcut.NONE), false, "mapillaryUpload", false);
     this.setEnabled(false);
-    MapillaryData.getInstance().addListener(this);
+    MapillaryLayer.getInstance().data.addListener(this);
   }
 
@@ -53 +53 @@
         && (int) pane.getValue() == JOptionPane.OK_OPTION) {
       if (dialog.sequence.isSelected()) {
-        OAuthUtils.uploadSequence(MapillaryData.getInstance()
+        OAuthUtils.uploadSequence(MapillaryLayer.getInstance().data
             .getSelectedImage().getSequence());
       }

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryZoomAction.java

@@ -9 +9 @@
 import org.openstreetmap.josm.actions.JosmAction;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryAbstractImage;
-import org.openstreetmap.josm.plugins.mapillary.MapillaryData;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryDataListener;
+import org.openstreetmap.josm.plugins.mapillary.MapillaryLayer;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryPlugin;
 import org.openstreetmap.josm.tools.Shortcut;
@@ -29 +29 @@
    */
   public MapillaryZoomAction() {
-    super(tr("Zoom to selected image"), MapillaryPlugin.getProvider("icon24.png"),
-        tr("Zoom to selected image"), Shortcut.registerShortcut(
-            "Zoom Mapillary",
+    super(tr("Zoom to selected image"), MapillaryPlugin
+        .getProvider("icon24.png"), tr("Zoom to selected image"), Shortcut
+        .registerShortcut("Zoom Mapillary",
             tr("Zoom to the currently selected Mapillary image"),
             KeyEvent.CHAR_UNDEFINED, Shortcut.NONE), false, "mapillaryZoom",
         false);
-    MapillaryData.getInstance().addListener(this);
+    MapillaryLayer.getInstance().data.addListener(this);
     this.setEnabled(false);
   }
@@ -41 +41 @@
   @Override
   public void actionPerformed(ActionEvent arg0) {
-    if (MapillaryData.getInstance().getSelectedImage() == null)
+    if (MapillaryLayer.getInstance().data.getSelectedImage() == null)
       throw new IllegalStateException();
-    Main.map.mapView.zoomTo(MapillaryData.getInstance().getSelectedImage()
-        .getLatLon());
+    Main.map.mapView.zoomTo(MapillaryLayer.getInstance().data
+        .getSelectedImage().getLatLon());
   }
 

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/gui/MapillaryExportDialog.java

@@ -18 +18 @@
 
 import org.openstreetmap.josm.plugins.mapillary.MapillaryAbstractImage;
-import org.openstreetmap.josm.plugins.mapillary.MapillaryData;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryImage;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryImportedImage;
+import org.openstreetmap.josm.plugins.mapillary.MapillaryLayer;
 
 /**
@@ -81 +81 @@
     this.group.add(this.rewrite);
     // Some options are disabled depending on the circumstances
-    if (MapillaryData.getInstance().getSelectedImage() == null
-        || !(MapillaryData.getInstance().getSelectedImage() instanceof MapillaryImage && ((MapillaryImage) MapillaryData
-            .getInstance().getSelectedImage()).getSequence() != null)) {
+    if (MapillaryLayer.getInstance().data.getSelectedImage() == null
+        || !(MapillaryLayer.getInstance().data.getSelectedImage() instanceof MapillaryImage && ((MapillaryImage) MapillaryLayer
+            .getInstance().data.getSelectedImage()).getSequence() != null)) {
       this.sequence.setEnabled(false);
     }
-    if (MapillaryData.getInstance().getMultiSelectedImages().isEmpty()) {
+    if (MapillaryLayer.getInstance().data.getMultiSelectedImages().isEmpty()) {
       this.selected.setEnabled(false);
     }
     this.rewrite.setEnabled(false);
-    for (MapillaryAbstractImage img : MapillaryData.getInstance().getImages())
+    for (MapillaryAbstractImage img : MapillaryLayer.getInstance().data
+        .getImages())
       if (img instanceof MapillaryImportedImage)
         this.rewrite.setEnabled(true);
@@ -158 +159 @@
     @Override
     public void actionPerformed(ActionEvent arg0) {
-      MapillaryExportDialog.this.choose.setEnabled(!MapillaryExportDialog.this.rewrite.isSelected());
+      MapillaryExportDialog.this.choose
+          .setEnabled(!MapillaryExportDialog.this.rewrite.isSelected());
       if (MapillaryExportDialog.this.rewrite.isSelected()) {
         this.lastPath = this.dlg.path.getText();

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/gui/MapillaryFilterDialog.java

@@ -26 +26 @@
 import org.openstreetmap.josm.gui.dialogs.ToggleDialog;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryAbstractImage;
-import org.openstreetmap.josm.plugins.mapillary.MapillaryData;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryDataListener;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryImage;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryImportedImage;
+import org.openstreetmap.josm.plugins.mapillary.MapillaryLayer;
 import org.openstreetmap.josm.tools.Shortcut;
 
@@ -79 +79 @@
   /** The the {@link JCheckBox} where the respective tag should be searched */
   private final JCheckBox[] SIGN_CHECKBOXES = { this.signFilter.maxSpeed,
-      this.signFilter.stop, this.signFilter.giveWay, this.signFilter.roundabout,
-      this.signFilter.access, this.signFilter.access, this.signFilter.intersection,
-      this.signFilter.direction, this.signFilter.direction, this.signFilter.intersection,
-      this.signFilter.uneven, this.signFilter.noParking, this.signFilter.noOvertaking,
+      this.signFilter.stop, this.signFilter.giveWay,
+      this.signFilter.roundabout, this.signFilter.access,
+      this.signFilter.access, this.signFilter.intersection,
+      this.signFilter.direction, this.signFilter.direction,
+      this.signFilter.intersection, this.signFilter.uneven,
+      this.signFilter.noParking, this.signFilter.noOvertaking,
       this.signFilter.crossing, this.signFilter.noTurn, this.signFilter.noTurn };
 
@@ -174 +176 @@
     boolean onlySigns = this.onlySigns.isSelected();
 
-    for (MapillaryAbstractImage img : MapillaryData.getInstance().getImages()) {
+    for (MapillaryAbstractImage img : MapillaryLayer.getInstance().data
+        .getImages()) {
       img.setVisible(true);
       if (img instanceof MapillaryImportedImage) {
@@ -205 +208 @@
       if (this.time.getSelectedItem().equals(TIME_LIST[1])) {
         if (img.getCapturedAt() < currentTime
-            - ((Integer) this.spinner.getValue()).longValue() * 365 * 24 * 60 * 60
-            * 1000) {
+            - ((Integer) this.spinner.getValue()).longValue() * 365 * 24 * 60
+            * 60 * 1000) {
           img.setVisible(false);
           continue;
@@ -213 +216 @@
       if (this.time.getSelectedItem().equals(TIME_LIST[2])) {
         if (img.getCapturedAt() < currentTime
-            - ((Integer) this.spinner.getValue()).longValue() * 30 * 24 * 60 * 60
-            * 1000) {
+            - ((Integer) this.spinner.getValue()).longValue() * 30 * 24 * 60
+            * 60 * 1000) {
           img.setVisible(false);
           continue;
@@ -274 +277 @@
     @Override
     public void actionPerformed(ActionEvent arg0) {
-      MapillaryFilterDialog.this.onlySigns.setEnabled(MapillaryFilterDialog.this.downloaded.isSelected());
+      MapillaryFilterDialog.this.onlySigns
+          .setEnabled(MapillaryFilterDialog.this.downloaded.isSelected());
     }
   }
@@ -318 +322 @@
     @Override
     public void actionPerformed(ActionEvent arg0) {
-      MapillaryFilterDialog.this.signChooser.setEnabled(MapillaryFilterDialog.this.onlySigns.isSelected());
+      MapillaryFilterDialog.this.signChooser
+          .setEnabled(MapillaryFilterDialog.this.onlySigns.isSelected());
     }
   }

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/gui/MapillaryMainDialog.java

@@ -23 +23 @@
 import org.openstreetmap.josm.gui.SideButton;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryAbstractImage;
-import org.openstreetmap.josm.plugins.mapillary.MapillaryData;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryDataListener;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryImage;
@@ -97 +96 @@
             tr("Open Mapillary main dialog"), KeyEvent.VK_M, Shortcut.NONE),
         200, false, MapillaryPreferenceSetting.class);
-    MapillaryData.getInstance().addListener(this);
+    MapillaryLayer.getInstance().data.addListener(this);
     addShortcuts();
     this.mapillaryImageDisplay = new MapillaryImageDisplay();
@@ -345 +344 @@
     @Override
     public void actionPerformed(ActionEvent e) {
-      MapillaryData.getInstance().selectNext();
+      MapillaryLayer.getInstance().data.selectNext();
     }
   }
@@ -367 +366 @@
     @Override
     public void actionPerformed(ActionEvent e) {
-      MapillaryData.getInstance().selectPrevious();
+      MapillaryLayer.getInstance().data.selectPrevious();
     }
   }
@@ -390 +389 @@
     public void actionPerformed(ActionEvent e) {
       if (MapillaryMainDialog.getInstance().getImage() != null) {
-        MapillaryData.getInstance().setSelectedImage(MapillaryLayer.RED, true);
+        MapillaryLayer.getInstance().data.setSelectedImage(MapillaryLayer.RED,
+            true);
       }
     }
@@ -414 +414 @@
     public void actionPerformed(ActionEvent e) {
       if (MapillaryMainDialog.getInstance().getImage() != null) {
-        MapillaryData.getInstance().setSelectedImage(MapillaryLayer.BLUE, true);
+        MapillaryLayer.getInstance().data.setSelectedImage(MapillaryLayer.BLUE,
+            true);
       }
     }

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/gui/MapillaryUploadDialog.java

@@ -5 +5 @@
 import javax.swing.JRadioButton;
 
-import org.openstreetmap.josm.plugins.mapillary.MapillaryData;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryImportedImage;
+import org.openstreetmap.josm.plugins.mapillary.MapillaryLayer;
 
 /**
@@ -28 +28 @@
 
     this.sequence = new JRadioButton("Upload selected sequence.");
-    if (MapillaryData.getInstance().getSelectedImage() == null
-        || !(MapillaryData.getInstance().getSelectedImage() instanceof MapillaryImportedImage))
+    if (MapillaryLayer.getInstance().data.getSelectedImage() == null
+        || !(MapillaryLayer.getInstance().data.getSelectedImage() instanceof MapillaryImportedImage))
       this.sequence.setEnabled(false);
     this.group.add(this.sequence);

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/mode/AbstractMode.java

@@ -28 +28 @@
   private final static int DOWNLOAD_COOLDOWN = 2000;
 
-  protected MapillaryData data = MapillaryData.getInstance();
+  protected MapillaryData data = MapillaryLayer.getInstance().data;
   private static SemiautomaticThread semiautomaticThread = new SemiautomaticThread();