Changeset 31435 in osm for applications/viewer/jmapviewer/src

Timestamp:

2015-08-02T17:20:58+02:00 (9 years ago)

Author:

donvip

Message:

[jmapviewer] fix a bunch of Sonar issues

Location:

applications/viewer/jmapviewer/src/org/openstreetmap/gui/jmapviewer

Files:

• Demo.java (modified) (1 diff)
• JobDispatcher.java (modified) (2 diffs)
• LayerGroup.java (modified) (1 diff)
• TileXY.java (modified) (1 diff)
• tilesources/AbstractTMSTileSource.java (modified) (2 diffs)
• tilesources/ScanexTileSource.java (modified) (2 diffs)
• tilesources/TemplatedTMSTileSource.java (modified) (1 diff)

applications/viewer/jmapviewer/src/org/openstreetmap/gui/jmapviewer/Demo.java

@@ -39 +39 @@
     private static final long serialVersionUID = 1L;
 
-    private JMapViewerTree treeMap = null;
-
-    private JLabel zoomLabel = null;
-    private JLabel zoomValue = null;
-
-    private JLabel mperpLabelName = null;
-    private JLabel mperpLabelValue = null;
+    private final JMapViewerTree treeMap;
+
+    private final JLabel zoomLabel;
+    private final JLabel zoomValue;
+
+    private final JLabel mperpLabelName;
+    private final JLabel mperpLabelValue;
 
     /**

applications/viewer/jmapviewer/src/org/openstreetmap/gui/jmapviewer/JobDispatcher.java

@@ -23 +23 @@
     private static int workerThreadMaxCount = 8;
 
-    private BlockingDeque<TileJob> jobQueue = new LinkedBlockingDeque<>();
+    private final BlockingDeque<TileJob> jobQueue = new LinkedBlockingDeque<>();
 
     private JobDispatcher() {
@@ -113 +113 @@
     }
 
-    protected JobThread addWorkerThread() {
+    private JobThread addWorkerThread() {
         JobThread jobThread = new JobThread(++workerThreadId);
         synchronized (this) {

applications/viewer/jmapviewer/src/org/openstreetmap/gui/jmapviewer/LayerGroup.java

@@ -53 +53 @@
     public void calculateVisibleTexts() {
         Boolean calculate = null;
-        if (layers != null && layers.size() > 0) {
+        if (layers != null && !layers.isEmpty()) {
             calculate = layers.get(0).isVisibleTexts();
             for (int i = 1; i < layers.size(); i++) {

applications/viewer/jmapviewer/src/org/openstreetmap/gui/jmapviewer/TileXY.java

@@ -10 +10 @@
      * x index of the tile (horizontal)
      */
-    private double x;
+    private final double x;
+
     /**
      * y number of the tile (vertical)
      */
-    private double y;
+    private final double y;
 
     /**

applications/viewer/jmapviewer/src/org/openstreetmap/gui/jmapviewer/tilesources/AbstractTMSTileSource.java

@@ -26 +26 @@
     protected String baseUrl;
     protected String id;
-    private Map<String, String> noTileHeaders;
-    private Map<String, String> metadataHeaders;
+    private final Map<String, String> noTileHeaders;
+    private final Map<String, String> metadataHeaders;
     protected int tileSize;
     protected OsmMercator osmMercator;
@@ -46 +46 @@
         this.metadataHeaders = info.getMetadataHeaders();
         this.tileSize = info.getTileSize();
-        osmMercator = new OsmMercator(this.tileSize);
+        this.osmMercator = new OsmMercator(this.tileSize);
     }
 

applications/viewer/jmapviewer/src/org/openstreetmap/gui/jmapviewer/tilesources/ScanexTileSource.java

@@ -43 +43 @@
     }
 
-    /* IRS by default */
+    /** IRS by default */
     private ScanexLayer layer = ScanexLayer.IRS;
 
@@ -50 +50 @@
         String url = info.getUrl();
 
-        for (ScanexLayer layer : ScanexLayer.values()) {
-            if (url.equalsIgnoreCase(layer.getName())) {
-                this.layer = layer;
-                /*
-                 * Override baseUrl and maxZoom in base class.
-                 */
+        for (ScanexLayer slayer : ScanexLayer.values()) {
+            if (url.equalsIgnoreCase(slayer.getName())) {
+                this.layer = slayer;
+                // Override baseUrl and maxZoom in base class.
                 this.baseUrl = DEFAULT_URL;
                 if (maxZoom == 0)

applications/viewer/jmapviewer/src/org/openstreetmap/gui/jmapviewer/tilesources/TemplatedTMSTileSource.java

@@ -34 +34 @@
     private Random rand = null;
     private String[] randomParts = null;
-    private Map<String, String> headers = new HashMap<>();
+    private final Map<String, String> headers = new HashMap<>();
 
     private static final String COOKIE_HEADER   = "Cookie";