Changeset 30457 in osm for applications

Timestamp:

2014-05-19T15:25:04+02:00 (10 years ago)

Author:

bastik

Message:

see #josm10045 - Could not rename file! when writing geolocation data

File:

• applications/editors/josm/plugins/photo_geotagging/src/org/openstreetmap/josm/plugins/photo_geotagging/GeotaggingAction.java (modified) (2 diffs)

applications/editors/josm/plugins/photo_geotagging/src/org/openstreetmap/josm/plugins/photo_geotagging/GeotaggingAction.java

@@ -1 @@
-//License: GPL (v2 or above)
+//License: GPL (v2 or later)
 package org.openstreetmap.josm.plugins.photo_geotagging;
 
@@ -283 +283 @@
             // instead, let's use new File(), which doesn't actually create a file
             // for getting a unique file name, we use UUID.randomUUID()
-            fileTmp = new File(file.getParentFile(), "img" + UUID.randomUUID() + ".jpg");
+            do {
+                fileTmp = new File(file.getParentFile(), "img" + UUID.randomUUID() + ".jpg");
+            } while (fileTmp.exists());
             if (debug) {
                 System.err.println("TMP: "+fileTmp.getAbsolutePath());
             }
             if (! file.renameTo(fileTmp))
-                throw new IOException(tr("Could not rename file!"));
+                throw new IOException(tr("Could not rename file {0} to {1}!", file, fileTmp));
 
             fileFrom = fileTmp;