Changeset 2905 in josm for trunk

Timestamp:

2010-01-29T21:26:50+01:00 (14 years ago)

Author:

jttt

Message:

Fixed #3275 Exception when number of values and display_values don't match

File:

• trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java

@@ -21 +21 @@
 import java.util.Arrays;
 import java.util.Collection;
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.LinkedHashMap;
@@ -327 +326 @@
             String[] value_array = values.split(",");
             String[] display_array;
+
             if(locale_display_values != null) {
                 display_array = locale_display_values.split(",");
@@ -332 +332 @@
                 display_array = display_values.split(",");
             } else {
+                display_array = value_array;
+            }
+
+            if (display_array.length != value_array.length) {
+                System.err.println(tr("Broken tagging preset \"{0}-{1}\" - number of items in display_values must be the same as in values", key, text));
                 display_array = value_array;
             }
@@ -642 +647 @@
                 MirroredInputStream s = new MirroredInputStream(source);
                 InputStream zip = s.getZipEntry("xml","preset");
-                if(zip != null)
+                if(zip != null) {
                     zipIcons = s.getFile();
+                }
                 InputStreamReader r;
                 try