Changeset 28599 in osm for applications/editors/josm

Timestamp:

2012-08-22T23:50:49+02:00 (13 years ago)

Author:

donvip

Message:

[josm_tag2link] See #josm7980 - Fix memory leak

File:

• applications/editors/josm/plugins/tag2link/src/org/openstreetmap/josm/plugins/tag2link/Tag2LinkPlugin.java (modified) (2 diffs)

applications/editors/josm/plugins/tag2link/src/org/openstreetmap/josm/plugins/tag2link/Tag2LinkPlugin.java ¶

@@ -44 +44 @@
     // private Tag2LinkPreferenceSetting preferenceSetting; TODO
 
+    private SelectionPopupListener selectionPopupListener;
+    private MembershipPopupListener membershipPopupListener;
+    private PropertyPopupListener propertyPopupListener;
+    private RelationPopupListener relationPopupListener;
+    
     /**
      * Initializes the plugin.
@@ -69 +74 @@
         if (newFrame != null) {
             // Initialize dialogs listeners only after the main frame is created
-            newFrame.selectionListDialog.addPopupMenuListener(new SelectionPopupListener(newFrame));
-            newFrame.propertiesDialog.addMembershipPopupMenuListener(new MembershipPopupListener(newFrame));
-            newFrame.propertiesDialog.addPropertyPopupMenuListener(new PropertyPopupListener(newFrame));
-            newFrame.relationListDialog.addPopupMenuListener(new RelationPopupListener(newFrame));
+            newFrame.selectionListDialog.addPopupMenuListener(selectionPopupListener = new SelectionPopupListener(newFrame));
+            newFrame.propertiesDialog.addMembershipPopupMenuListener(membershipPopupListener = new MembershipPopupListener(newFrame));
+            newFrame.propertiesDialog.addPropertyPopupMenuListener(propertyPopupListener = new PropertyPopupListener(newFrame));
+            newFrame.relationListDialog.addPopupMenuListener(relationPopupListener = new RelationPopupListener(newFrame));
+        } else if (oldFrame != null) {
+            // Remove listeners from previous frame to avoid memory leaks
+            if (oldFrame.selectionListDialog != null) {
+                oldFrame.selectionListDialog.removePopupMenuListener(selectionPopupListener);
+            }
+            if (oldFrame.propertiesDialog != null) {
+                oldFrame.propertiesDialog.removeMembershipPopupMenuListener(membershipPopupListener);
+                oldFrame.propertiesDialog.removePropertyPopupMenuListener(propertyPopupListener);
+            }
+            if (oldFrame.relationListDialog != null) {
+                oldFrame.relationListDialog.removePopupMenuListener(relationPopupListener);
+            }
+            selectionPopupListener = null;
+            membershipPopupListener = null;
+            propertyPopupListener = null;
+            relationPopupListener = null;
         }
     }