Changeset 28472 in osm for applications/editors/josm/plugins/wikipedia/src

Timestamp:

2012-07-11T22:35:45+02:00 (12 years ago)

Author:

simon04

Message:

JOSM/wikipedia: fix NPE bug, add link to documentation.

File:

• applications/editors/josm/plugins/wikipedia/src/org/wikipedia/WikipediaToggleDialog.java (modified) (1 diff)

applications/editors/josm/plugins/wikipedia/src/org/wikipedia/WikipediaToggleDialog.java

@@ -229 +229 @@
             articleNames.add(i.wikipediaArticle);
         }
-        final String url = "https://toolserver.org/~simon04/getGeoJSONStatus.php"
-                + "?lang=" + wikipediaLang.get()
-                + "&articles=" + encodeURL(Utils.join(",", articleNames));
-        System.out.println("Wikipedia: GET " + url);
         Map<String, Boolean> status = new HashMap<String, Boolean>();
-
-        try {
-            final Scanner scanner = new Scanner(new URL(url).openStream()).useDelimiter("\n");
-            while (scanner.hasNext()) {
-                //[article]\t[0|1]
-                final String line = scanner.next();
-                final String[] x = line.split("\t");
-                if (x.length == 2) {
-                    status.put(x[0], "1".equals(x[1]));
-                } else {
-                    System.err.println("Unknown element "+line);
-                }
-            }
-        } catch (Exception ex) {
-            throw new RuntimeException(ex);
+        if (!articleNames.isEmpty()) {
+            final String url = "https://toolserver.org/~simon04/getGeoJSONStatus.php"
+                    + "?lang=" + wikipediaLang.get()
+                    + "&articles=" + encodeURL(Utils.join(",", articleNames));
+            System.out.println("Wikipedia: GET " + url);
+
+            try {
+                final Scanner scanner = new Scanner(new URL(url).openStream()).useDelimiter("\n");
+                while (scanner.hasNext()) {
+                    //[article]\t[0|1]
+                    final String line = scanner.next();
+                    final String[] x = line.split("\t");
+                    if (x.length == 2) {
+                        status.put(x[0], "1".equals(x[1]));
+                    } else {
+                        System.err.println("Unknown element " + line);
+                    }
+                }
+            } catch (Exception ex) {
+                throw new RuntimeException(ex);
+            }
         }