Changeset 2795 in josm for trunk

Timestamp:

2010-01-09T21:16:03+01:00 (15 years ago)

Author:

jttt

Message:

Allow to load incomplete gpx files

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/gpx/GpxData.java (modified) (1 diff)
• gui/layer/geoimage/CorrelateGpxWithImages.java (modified) (2 diffs)
• io/BoundingBoxDownloader.java (modified) (1 diff)
• io/GpxImporter.java (modified) (3 diffs)
• io/GpxReader.java (modified) (8 diffs)

trunk/src/org/openstreetmap/josm/data/gpx/GpxData.java

@@ -79 +79 @@
     }
 
+    public boolean isEmpty() {
+        return !hasRoutePoints() && !hasTrackPoints() && waypoints.isEmpty();
+    }
+
     // FIXME might perhaps use visitor pattern?
     public Bounds recalculateBounds() {

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/CorrelateGpxWithImages.java

@@ -179 +179 @@
                         iStream = new FileInputStream(sel);
                     }
-                    data = new GpxReader(iStream, sel).data;
+                    GpxReader reader = new GpxReader(iStream);
+                    reader.parse(false);
+                    data = reader.data;
                     data.storageFile = sel;
 
@@ -874 +876 @@
 
                     tfTimezone.setText(formatTimezone(timezone));
-                    tfOffset.setText(Long.toString(delta + dayOffset*24*60*60l));    // add the day offset to the offset field
+                    tfOffset.setText(Long.toString(delta + 24*60*60L*dayOffset));    // add the day offset to the offset field
 
                     tfTimezone.getDocument().addDocumentListener(statusBarListener);

trunk/src/org/openstreetmap/josm/io/BoundingBoxDownloader.java

@@ -51 +51 @@
                 }
                 progressMonitor.setTicks(0);
-                GpxData currentGpx = new GpxReader(in, null).data;
+                GpxReader reader = new GpxReader(in);
+                reader.parse(false);
+                GpxData currentGpx = reader.data;
                 if (result == null) {
                     result = currentGpx;

trunk/src/org/openstreetmap/josm/io/GpxImporter.java

@@ -11 +11 @@
 import java.util.zip.GZIPInputStream;
 
+import javax.swing.JOptionPane;
 import javax.swing.SwingUtilities;
 
@@ -45 +46 @@
                 }
             }
-            final GpxReader r = new GpxReader(is, file.getAbsoluteFile().getParentFile());
+            final GpxReader r = new GpxReader(is);
+            final boolean parsedProperly = r.parse(true);
             r.data.storageFile = file;
             final GpxLayer gpxLayer = new GpxLayer(r.data, fn, true);
@@ -61 +63 @@
                             Main.main.addLayer(ml);
                         }
+                    }
+                    if (!parsedProperly) {
+                        JOptionPane.showMessageDialog(null, tr("Error occured while parsing gpx file {0}. Only part of the file will be available", file.getName()));
                     }
                 }

trunk/src/org/openstreetmap/josm/io/GpxReader.java

@@ -6 +6 @@
 import static org.openstreetmap.josm.tools.I18n.tr;
 
-import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
@@ -13 +12 @@
 import java.util.Collection;
 import java.util.LinkedList;
+import java.util.List;
 import java.util.Map;
 import java.util.Stack;
@@ -41 +41 @@
      */
     public GpxData data;
-    public enum State { init, metadata, wpt, rte, trk, ext, author, link, trkseg, copyright}
+    private enum State { init, metadata, wpt, rte, trk, ext, author, link, trkseg, copyright}
+    private InputSource inputSource;
 
     private class Parser extends DefaultHandler {
@@ -55 +56 @@
         private GpxLink currentLink;
         private Stack<State> states;
+        private final Stack<String> elements = new Stack<String>();
 
         private StringBuffer accumulator = new StringBuffer();
@@ -81 +83 @@
 
         @Override public void startElement(String namespaceURI, String qName, String rqName, Attributes atts) throws SAXException {
+            elements.push(qName);
             switch(currentState) {
             case init:
@@ -211 +214 @@
         @SuppressWarnings("unchecked")
         @Override public void endElement(String namespaceURI, String qName, String rqName) {
+            elements.pop();
             switch (currentState) {
             case metadata:
@@ -333 +337 @@
             data = currentData;
         }
+
+        public void tryToFinish() throws SAXException {
+            List<String> remainingElements = new ArrayList<String>(elements);
+            for (int i=remainingElements.size() - 1; i >= 0; i--) {
+                endElement(null, remainingElements.get(i), null);
+            }
+            endDocument();
+        }
     }
 
@@ -338 +350 @@
      * Parse the input stream and store the result in trackData and markerData
      *
-     * @param relativeMarkerPath The directory to use as relative path for all &lt;wpt&gt;
-     *    marker tags. Maybe <code>null</code>, in which case no relative urls are constructed for the markers.
      */
-    public GpxReader(InputStream source, File relativeMarkerPath) throws SAXException, IOException {
-
+    public GpxReader(InputStream source) throws IOException {
+        this.inputSource = new InputSource(new InputStreamReader(source, "UTF-8"));
+    }
+
+    /**
+     * 
+     * @return True if file was properly parsed, false if there was error during parsing but some data were parsed anyway
+     * @throws SAXException
+     * @throws IOException
+     */
+    public boolean parse(boolean tryToFinish) throws SAXException, IOException {
         Parser parser = new Parser();
-        InputSource inputSource = new InputSource(new InputStreamReader(source, "UTF-8"));
         try {
             SAXParserFactory factory = SAXParserFactory.newInstance();
             factory.setNamespaceAware(true);
             factory.newSAXParser().parse(inputSource, parser);
+            return true;
+        } catch (SAXException e) {
+            if (tryToFinish) {
+                parser.tryToFinish();
+                if (parser.currentData.isEmpty())
+                    throw e;
+                return false;
+            } else
+                throw e;
         } catch (ParserConfigurationException e) {
             e.printStackTrace(); // broken SAXException chaining