Changeset 2629 in josm for trunk/src/org/openstreetmap

Timestamp:

2009-12-13T19:31:06+01:00 (14 years ago)

Author:

bastiK

Message:

geoimage: usability - allow clicking on the image symbols only when in select mode

• introduces MapModeChangeListener

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• MapFrame.java (modified) (4 diffs)
• layer/geoimage/GeoImageLayer.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/gui/MapFrame.java

@@ -9 +9 @@
 import java.awt.event.MouseWheelListener;
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.List;
+import java.util.concurrent.CopyOnWriteArrayList;
 
 import javax.swing.AbstractButton;
@@ -216 +218 @@
 
     /**
-     * 
+     *
      */
     public void tearDownDialogsPane() {
@@ -257 +259 @@
      * @param mapMode   The new mode to set.
      */
-    public void selectMapMode(MapMode mapMode) {
-        if (mapMode == this.mapMode)
+    public void selectMapMode(MapMode newMapMode) {
+        MapMode oldMapMode = this.mapMode;
+        if (newMapMode == oldMapMode)
             return;
-        if (this.mapMode != null) {
-            this.mapMode.exitMode();
-        }
-        this.mapMode = mapMode;
-        mapMode.enterMode();
+        if (oldMapMode != null) {
+            oldMapMode.exitMode();
+        }
+        this.mapMode = newMapMode;
+        newMapMode.enterMode();
+        fireMapModeChanged(oldMapMode, newMapMode);
     }
 
@@ -319 +323 @@
         return dialogsPanel.getWidth();
     }
+
+    /**
+     * Interface to notify listeners of the change of the mapMode.
+     */
+    public interface MapModeChangeListener {
+        void mapModeChange(MapMode oldMapMode, MapMode newMapMode);
+    }
+
+    /**
+     * the mapMode listeners
+     */
+    private static final Collection<MapModeChangeListener> mapModeChangeListeners = new CopyOnWriteArrayList<MapModeChangeListener>();
+     /**
+     * Adds a mapMode change listener
+     *
+     * @param listener the listener. Ignored if null or already registered.
+     */
+    public static void addMapModeChangeListener(MapModeChangeListener listener) {
+        if (listener != null && ! mapModeChangeListeners.contains(listener)) {
+            mapModeChangeListeners.add(listener);
+        }
+    }
+    /**
+     * Removes a mapMode change listener
+     *
+     * @param listener the listener. Ignored if null or already registered.
+     */
+    public static void removeMapModeChangeListener(MapModeChangeListener listener) {
+        if (listener != null && mapModeChangeListeners.contains(listener)) {
+            mapModeChangeListeners.remove(listener);
+        }
+    }
+
+    protected static void fireMapModeChanged(MapMode oldMapMode, MapMode newMapMode) {
+        for (MapModeChangeListener l : mapModeChangeListeners) {
+            l.mapModeChange(oldMapMode, newMapMode);
+        }
+    }
 }

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/GeoImageLayer.java

@@ -46 +46 @@
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.actions.RenameLayerAction;
+import org.openstreetmap.josm.actions.mapmode.MapMode;
 import org.openstreetmap.josm.data.Bounds;
 import org.openstreetmap.josm.data.coor.CachedLatLon;
@@ -51 +52 @@
 import org.openstreetmap.josm.data.osm.visitor.BoundingXYVisitor;
 import org.openstreetmap.josm.gui.ExtendedDialog;
+import org.openstreetmap.josm.gui.MapFrame;
+import org.openstreetmap.josm.gui.MapFrame.MapModeChangeListener;
 import org.openstreetmap.josm.gui.MapView;
 import org.openstreetmap.josm.gui.PleaseWaitRunnable;
@@ -646 +649 @@
 
     private MouseAdapter mouseAdapter = null;
+    private MapModeChangeListener mapModeListener = null;
 
     private void hook_up_mouse_events() {
@@ -689 +693 @@
             }
         };
-        Main.map.mapView.addMouseListener(mouseAdapter);
+
+        mapModeListener = new MapModeChangeListener() {
+            public void mapModeChange(MapMode oldMapMode, MapMode newMapMode) {
+                if (newMapMode instanceof org.openstreetmap.josm.actions.mapmode.SelectAction) {
+                    Main.map.mapView.addMouseListener(mouseAdapter);
+                } else {
+                    Main.map.mapView.removeMouseListener(mouseAdapter);
+                }
+            }
+        };
+
+        Main.map.addMapModeChangeListener(mapModeListener);
+        mapModeListener.mapModeChange(null, Main.map.mapMode);
+
         MapView.addLayerChangeListener(new LayerChangeListener() {
             public void activeLayerChange(Layer oldLayer, Layer newLayer) {
-                if (newLayer == GeoImageLayer.this && currentPhoto >= 0) {
-                    Main.main.map.repaint();
-                    ImageViewerDialog.showImage(GeoImageLayer.this, data.get(currentPhoto));
+                if (newLayer == GeoImageLayer.this) {
+                    // only in select mode it is possible to click the images
+                    Main.map.selectSelectTool(false);
                 }
             }
@@ -707 +724 @@
                     }
                     Main.map.mapView.removeMouseListener(mouseAdapter);
+                    Main.map.removeMapModeChangeListener(mapModeListener);
                     currentPhoto = -1;
                     data.clear();