Changeset 2579 in josm

Timestamp:

2009-12-06T09:21:50+01:00 (15 years ago)

Author:

jttt

Message:

Removed Relation.isIncomplete - it was overriding OsmPrimitive.isIncomplete() and it was completely useless - it could not ever return true

Location:

trunk

Files:

• .settings/org.eclipse.jdt.core.prefs (modified) (3 diffs)
• src/org/openstreetmap/josm/data/osm/Relation.java (modified) (1 diff)

trunk/.settings/org.eclipse.jdt.core.prefs

@@ -1 @@
-#Thu Jul 09 20:42:21 CEST 2009
+#Sun Dec 06 09:20:07 CET 2009
 eclipse.preferences.version=1
 org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
@@ -11 +11 @@
 org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
 org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
+org.eclipse.jdt.core.compiler.problem.comparingIdentical=warning
+org.eclipse.jdt.core.compiler.problem.deadCode=warning
 org.eclipse.jdt.core.compiler.problem.deprecation=warning
 org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled
@@ -30 +32 @@
 org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning
 org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=warning
-org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore
+org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=warning
+org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=warning
 org.eclipse.jdt.core.compiler.problem.missingSerialVersion=ignore
+org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=warning
 org.eclipse.jdt.core.compiler.problem.noEffectAssignment=error
 org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning

trunk/src/org/openstreetmap/josm/data/osm/Relation.java

@@ -234 +234 @@
     }
 
-    // seems to be different from member "incomplete" - FIXME
-    public boolean isIncomplete() {
-        for (RelationMember m : members)
-            if (m.getMember() == null)
-                return true;
-        return false;
-    }
-
     public RelationMember firstMember() {
         if (isIncomplete()) return null;