Changeset 2497 in josm for trunk/src/org

Timestamp:

2009-11-22T12:06:30+01:00 (14 years ago)

Author:

jttt

Message:

Added Dataset.beginUpdate and Dataset.endUpdate that can be used to temporarily stop dataset events in case of big changes

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/UnGlueAction.java (modified) (2 diffs)
• data/osm/DataSet.java (modified) (2 diffs)
• data/osm/DataSetListener.java (modified) (6 diffs)
• data/osm/DataSetMerger.java (modified) (1 diff)
• gui/dialogs/RelationListDialog.java (modified) (1 diff)
• gui/history/HistoryBrowserModel.java (modified) (1 diff)
• io/OsmReader.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/actions/UnGlueAction.java

@@ -90 +90 @@
                 int count = 0;
                 for (Way w : OsmPrimitive.getFilteredList(n.getReferrers(), Way.class)) {
-                    if (w.isDeleted() || w.incomplete || w.getNodesCount() < 1) {
+                    if (w.isDeleted() || w.incomplete) {
                         continue;
                     }
@@ -353 +353 @@
             // modify all ways containing the nodes
             for (Way w : OsmPrimitive.getFilteredList(selectedNode.getReferrers(), Way.class)) {
-                if (w.isDeleted() || w.incomplete || w.getNodesCount() < 1) {
+                if (w.isDeleted() || w.incomplete) {
                     continue;
                 }

trunk/src/org/openstreetmap/josm/data/osm/DataSet.java

@@ -47 +47 @@
     private Map<PrimitiveId, OsmPrimitive> primitivesMap = allPrimitives.foreignKey(new IdHash());
     private List<DataSetListener> listeners = new ArrayList<DataSetListener>();
+    // Number of open calls to beginUpdate
+    private int updateCount;
 
     /**
@@ -796 +798 @@
     }
 
+    /**
+     * Can be called before bigger changes on dataset. Events are disabled until {@link #endUpdate()}.
+     * {@link DataSetListener#dataChanged()} event is triggered after end of changes
+     * <br>
+     * Typical usecase should look like this:
+     * <pre>
+     * ds.beginUpdate();
+     * try {
+     *   ...
+     * } finally {
+     *   ds.endUpdate();
+     * }
+     * </pre>
+     */
+    public void beginUpdate() {
+        updateCount++;
+    }
+
+    /**
+     * @see DataSet#beginUpdate()
+     */
+    public void endUpdate() {
+        if (updateCount > 0) {
+            updateCount--;
+            if (updateCount == 0) {
+                fireDataChanged();
+            }
+        } else
+            throw new AssertionError("endUpdate called without beginUpdate");
+    }
+
+    private void fireDataChanged() {
+        if (updateCount == 0) {
+            for (DataSetListener dsl : listeners) {
+                dsl.dataChanged();
+            }
+        }
+    }
+
     void firePrimitivesAdded(Collection<? extends OsmPrimitive> added) {
-        for (DataSetListener dsl : listeners) {
-            dsl.primtivesAdded(added);
+        if (updateCount == 0) {
+            for (DataSetListener dsl : listeners) {
+                dsl.primtivesAdded(added);
+            }
         }
     }
 
     void firePrimitivesRemoved(Collection<? extends OsmPrimitive> removed) {
-        for (DataSetListener dsl : listeners) {
-            dsl.primtivesRemoved(removed);
+        if (updateCount == 0) {
+            for (DataSetListener dsl : listeners) {
+                dsl.primtivesRemoved(removed);
+            }
         }
     }
 
     void fireTagsChanged(OsmPrimitive prim) {
-        for (DataSetListener dsl : listeners) {
-            dsl.tagsChanged(prim);
+        if (updateCount == 0) {
+            for (DataSetListener dsl : listeners) {
+                dsl.tagsChanged(prim);
+            }
         }
     }
 
     void fireRelationMembersChanged(Relation r) {
-        for (DataSetListener dsl : listeners) {
-            dsl.relationMembersChanged(r);
-        }
-    }
-
-    public void fireNodeMoved(Node node) {
+        if (updateCount == 0) {
+            for (DataSetListener dsl : listeners) {
+                dsl.relationMembersChanged(r);
+            }
+        }
+    }
+
+    void fireNodeMoved(Node node) {
         reindexNode(node);
-        for (DataSetListener dsl : listeners) {
-            dsl.nodeMoved(node);
-        }
-    }
-
-    public void fireWayNodesChanged(Way way) {
+        if (updateCount == 0) {
+            for (DataSetListener dsl : listeners) {
+                dsl.nodeMoved(node);
+            }
+        }
+    }
+
+    void fireWayNodesChanged(Way way) {
         reindexWay(way);
-        for (DataSetListener dsl : listeners) {
-            dsl.wayNodesChanged(way);
+        if (updateCount == 0) {
+            for (DataSetListener dsl : listeners) {
+                dsl.wayNodesChanged(way);
+            }
         }
     }

trunk/src/org/openstreetmap/josm/data/osm/DataSetListener.java

@@ -37 +37 @@
      * @param added A collection of newly-visible primitives
      */
-    public void primtivesAdded(Collection<? extends OsmPrimitive> added);
+    void primtivesAdded(Collection<? extends OsmPrimitive> added);
 
     /**
@@ -45 +45 @@
      * @param removed A collection of newly-invisible primitives
      */
-    public void primtivesRemoved(Collection<? extends OsmPrimitive> removed);
+    void primtivesRemoved(Collection<? extends OsmPrimitive> removed);
 
     /**
@@ -53 +53 @@
      * @param prim the primitive, whose tags were affected.
      */
-    public void tagsChanged(OsmPrimitive prim);
+    void tagsChanged(OsmPrimitive prim);
 
     /**
@@ -59 +59 @@
      * @param node The node that was moved.
      */
-    public void nodeMoved(Node node);
+    void nodeMoved(Node node);
 
     /**
@@ -65 +65 @@
      * @param way The way that was modified.
      */
-    public void wayNodesChanged(Way way);
+    void wayNodesChanged(Way way);
 
     /**
@@ -71 +71 @@
      * @param relation The relation that was modified.
      */
-    public void relationMembersChanged(Relation r);
+    void relationMembersChanged(Relation r);
 
+    /**
+     * Called after big changes in dataset. Usually other events are stopped using Dataset.beginUpdate() and
+     * after operation is completed (Dataset.endUpdate()), {@link #dataChanged()} is called.
+     */
+    void dataChanged();
 
 }

trunk/src/org/openstreetmap/josm/data/osm/DataSetMerger.java

@@ -333 +333 @@
         if (sourceDataSet == null)
             return;
-        for (Node node: sourceDataSet.getNodes()) {
-            mergePrimitive(node);
-        }
-        for (Way way: sourceDataSet.getWays()) {
-            mergePrimitive(way);
-        }
-        for (Relation relation: sourceDataSet.getRelations()) {
-            mergePrimitive(relation);
-        }
-        fixReferences();
+        targetDataSet.beginUpdate();
+        try {
+            for (Node node: sourceDataSet.getNodes()) {
+                mergePrimitive(node);
+            }
+            for (Way way: sourceDataSet.getWays()) {
+                mergePrimitive(way);
+            }
+            for (Relation relation: sourceDataSet.getRelations()) {
+                mergePrimitive(relation);
+            }
+            fixReferences();
+        } finally {
+            targetDataSet.endUpdate();
+        }
     }
 

trunk/src/org/openstreetmap/josm/gui/dialogs/RelationListDialog.java

@@ -788 +788 @@
     }
 
+    public void dataChanged() {
+        Layer l = Main.main.getEditLayer();
+        if (l != null) {
+            initFromLayer(l);
+        }
+    }
+
     /* ---------------------------------------------------------------------------------- */
     /* DataSetListener                                                                    */

trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserModel.java

@@ -822 +822 @@
     }
 
+    public void dataChanged() {
+        dataChanged(getEditLayer());
+    }
+
     /* ---------------------------------------------------------------------- */
     /* DataChangeListener                                                    */

trunk/src/org/openstreetmap/josm/io/OsmReader.java

@@ -563 +563 @@
 
             progressMonitor.subTask(tr("Preparing data set..."));
-            reader.processNodesAfterParsing();
-            reader.processWaysAfterParsing();
-            reader.processRelationsAfterParsing();
+            reader.ds.beginUpdate();
+            try {
+                reader.processNodesAfterParsing();
+                reader.processWaysAfterParsing();
+                reader.processRelationsAfterParsing();
+            } finally {
+                reader.ds.endUpdate();
+            }
             progressMonitor.worked(1);
             return reader.getDataSet();