Changeset 2475 in josm for trunk/src/org/openstreetmap

Timestamp:

2009-11-19T08:51:27+01:00 (14 years ago)

Author:

jttt

Message:

Added methods showNotify and hideNotify to ToggleDialog. Useful to register listeners only when dialog is shown and expanded

Location:

trunk/src/org/openstreetmap/josm/gui/dialogs

Files:

• DialogsPanel.java (modified) (8 diffs)
• ToggleDialog.java (modified) (6 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/DialogsPanel.java

@@ -3 +3 @@
 package org.openstreetmap.josm.gui.dialogs;
 
-import static org.openstreetmap.josm.tools.I18n.tr;
-
 import java.awt.Dimension;
-
 import java.util.ArrayList;
 import java.util.List;
@@ -14 +11 @@
 import javax.swing.JSplitPane;
 
-import org.openstreetmap.josm.gui.MultiSplitLayout;
+import org.openstreetmap.josm.gui.MultiSplitPane;
+import org.openstreetmap.josm.gui.MultiSplitLayout.Divider;
+import org.openstreetmap.josm.gui.MultiSplitLayout.Leaf;
 import org.openstreetmap.josm.gui.MultiSplitLayout.Node;
-import org.openstreetmap.josm.gui.MultiSplitLayout.Leaf;
-import org.openstreetmap.josm.gui.MultiSplitLayout.Divider;
 import org.openstreetmap.josm.gui.MultiSplitLayout.Split;
-import org.openstreetmap.josm.gui.MultiSplitPane;
-import org.openstreetmap.josm.Main;
 
 public class DialogsPanel extends JPanel {
@@ -31 +26 @@
      */
     private List<JPanel> panels = new ArrayList<JPanel>();
-    
+
     final private JSplitPane parent;
     public DialogsPanel(JSplitPane parent) {
@@ -39 +34 @@
     private boolean initialized = false;
     public void initialize(List<ToggleDialog> allDialogs) {
-        if (initialized) {
+        if (initialized)
             throw new IllegalStateException();
-        }
         initialized = true;
         this.allDialogs = allDialogs;
@@ -56 +50 @@
                  * entire Window is resized.
                  */
+                @Override
                 public Dimension getMinimumSize() {
                     return new Dimension(0, 40);
@@ -88 +83 @@
         INVISIBLE_TO_DEFAULT,
         COLLAPSED_TO_DEFAULT,
-    /*  INVISIBLE_TO_COLLAPSED,    does not happen */
+        /*  INVISIBLE_TO_COLLAPSED,    does not happen */
         ELEMENT_SHRINKS         /* else. (Remaining elements have more space.) */
     };
@@ -157 +152 @@
             }
         } else {
-            if (triggeredBy == null) {
+            if (triggeredBy == null)
                 throw new IllegalArgumentException();
-            }
 
             int sumP = 0;   // sum of preferred heights of dialogs in default view (without the triggering dialog)
@@ -285 +279 @@
     public void destroy() {
         for (ToggleDialog t : allDialogs) {
-            t.closeDetachedDialog();
+            t.destroy();
         }
     }

trunk/src/org/openstreetmap/josm/gui/dialogs/ToggleDialog.java

@@ -163 +163 @@
         toggleAction.putValue("selected", false);
         toggleAction.putValue("selected", true);
+        showNotify();
     }
 
@@ -173 +174 @@
         setIsShowing(false);
         toggleAction.putValue("selected", false);
+        hideNotify();
     }
 
@@ -204 +206 @@
      */
     public void collapse() {
-        setContentVisible(false);
-        setIsCollapsed(true);
-        setPreferredSize(new Dimension(0,20));
-        setMaximumSize(new Dimension(Integer.MAX_VALUE,20));
-        setMinimumSize(new Dimension(Integer.MAX_VALUE,20));
-        lblMinimized.setIcon(ImageProvider.get("misc", "minimized"));
+        if (isShowing && isDocked && !isCollapsed) {
+            setContentVisible(false);
+            setIsCollapsed(true);
+            setPreferredSize(new Dimension(0,20));
+            setMaximumSize(new Dimension(Integer.MAX_VALUE,20));
+            setMinimumSize(new Dimension(Integer.MAX_VALUE,20));
+            lblMinimized.setIcon(ImageProvider.get("misc", "minimized"));
+            hideNotify();
+        }
     }
 
@@ -216 +221 @@
      */
     protected void expand() {
-        setContentVisible(true);
-        setIsCollapsed(false);
-        setPreferredSize(new Dimension(0,preferredHeight));
-        setMaximumSize(new Dimension(Integer.MAX_VALUE, Integer.MAX_VALUE));
-        lblMinimized.setIcon(ImageProvider.get("misc", "normal"));
+        if (isShowing && isDocked && isCollapsed) {
+            setContentVisible(true);
+            setIsCollapsed(false);
+            setPreferredSize(new Dimension(0,preferredHeight));
+            setMaximumSize(new Dimension(Integer.MAX_VALUE, Integer.MAX_VALUE));
+            lblMinimized.setIcon(ImageProvider.get("misc", "normal"));
+            showNotify();
+        }
     }
 
@@ -237 +245 @@
     }
 
+    public void destroy() {
+        closeDetachedDialog();
+        hideNotify();
+    }
+
     /**
      * Closes the the detached dialog if this toggle dialog is currently displayed
@@ -248 +261 @@
             detachedDialog.dispose();
         }
+    }
+
+    /**
+     * Called when toggle dialog is shown (after it was created or expanded). Descendants may overwrite this
+     * method, it's a good place to register listeners needed to keep dialog updated
+     */
+    public void showNotify() {
+
+    }
+
+    /**
+     * Called when toggle dialog is hidden (collapsed, removed, MapFrame is removed, ...). Good place to unregister
+     * listeners
+     */
+    public void hideNotify() {
+
     }