Changeset 23103 in osm for applications/editors/josm/plugins/wayselector

Timestamp:

2010-09-10T21:51:20+02:00 (14 years ago)

Author:

skela

Message:

'Optimize WaySelection.findWay().'

Location:

applications/editors/josm/plugins/wayselector

Files:

• build.xml (modified) (1 diff)
• src/org/openstreetmap/josm/plugins/wayselector/WaySelection.java (modified) (1 diff)

applications/editors/josm/plugins/wayselector/build.xml

@@ -31 +31 @@
 
         <!-- enter the SVN commit message -->
-        <property name="commit.message" value="Do not mutate the collection of selected ways. Convert TAB to spaces." />
+        <property name="commit.message" value="Optimize WaySelection.findWay()." />
         <!-- enter the *lowest* JOSM version this plugin is currently compatible with -->
         <property name="plugin.main.version" value="3095" />

applications/editors/josm/plugins/wayselector/src/org/openstreetmap/josm/plugins/wayselector/WaySelection.java

@@ -69 +69 @@
      @param node perimeter node from which to extend the selection
      @return a way by which to extend the selection, or null */
-    private Way findWay(Collection<OsmPrimitive> selection, Node node) {
-        TreeSet<Way> foundWays = new TreeSet<Way>();
+    private static Way findWay(Collection<OsmPrimitive> selection, Node node) {
+        Way foundWay = null;
 
         for (Way way : OsmPrimitive.getFilteredList(node.getReferrers(),
-                                                    Way.class))
-            if (way.getNodesCount() >= 2 && !selection.contains(way) &&
-                way.isFirstLastNode(node))
-                foundWays.add(way);
+                                                    Way.class)) {
+            if (way.getNodesCount() < 2 || !way.isFirstLastNode(node)
+                || selection.contains(way))
+                continue;
 
-        return foundWays.size() == 1 ? foundWays.first() : null;
+            /* A previously unselected way was found that is connected
+            to the node. */
+            if (foundWay != null)
+                /* This is not the only qualifying way. There is a
+                branch at the node, and we cannot extend the selection. */
+                return null;
+
+            /* Remember the first found qualifying way. */
+            foundWay = way;
+        }
+
+        /* Return the only way found, or null if none was found. */
+        return foundWay;
     }