Changeset 19645 in josm

Timestamp:

2026-10-09T17:06:57+02:00 (7 hours ago)

Author:

gaben

Message:

fix #24863 - keep auto filter buttons unchanged while the data layer is uploaded

File:

• trunk/src/org/openstreetmap/josm/gui/autofilter/AutoFilterManager.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/autofilter/AutoFilterManager.java

@@ -8 +8 @@
 import java.util.Arrays;
 import java.util.Collection;
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
@@ -140 +139 @@
     private synchronized void updateButtons() {
         MapFrame map = MainApplication.getMap();
-        if (enabledRule != null && map != null
+        // The active data set is null while the data layer is uploaded, keep the buttons as they are
+        DataSet ds = MainApplication.getLayerManager().getActiveDataSet();
+        if (enabledRule != null && map != null && ds != null
                 && enabledRule.getMinZoomLevel() <= Selector.GeneralSelector.scale2level(map.mapView.getDist100Pixel())) {
             // Retrieve the values from current rule visible on screen
-            NavigableSet<Integer> values = getNumericValues();
+            NavigableSet<Integer> values = getNumericValues(ds);
             // Make sure current auto filter buttons remain visible even if no data is found, to allow user to disable them
             for (AutoFilter currentAutoFilter : currentAutoFilters) {
@@ -324 +325 @@
     }
 
-    private synchronized NavigableSet<Integer> getNumericValues() {
-        DataSet ds = MainApplication.getLayerManager().getActiveDataSet();
-        if (ds == null) {
-            return Collections.emptyNavigableSet();
-        }
+    private synchronized NavigableSet<Integer> getNumericValues(DataSet ds) {
         BBox bbox = MainApplication.getMap().mapView.getState().getViewArea().getLatLonBoundsBox().toBBox();
         NavigableSet<Integer> values = new TreeSet<>();