Changeset 19443 in josm

Timestamp:

2025-10-09T11:03:09+02:00 (5 weeks ago)

Author:

GerdP

Message:

fix #24480: 19437 introduced client side tag checking impacting private server.

• implement boolean preference upload.check-maxlength-value which allows to disable the maxlength check of tag values on upload

File:

• trunk/src/org/openstreetmap/josm/actions/upload/ApiPreconditionCheckerHook.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/actions/upload/ApiPreconditionCheckerHook.java

@@ -14 +14 @@
 import org.openstreetmap.josm.data.osm.Tagged;
 import org.openstreetmap.josm.data.osm.Way;
+import org.openstreetmap.josm.data.preferences.AbstractProperty;
+import org.openstreetmap.josm.data.preferences.BooleanProperty;
 import org.openstreetmap.josm.gui.ExceptionDialogUtil;
 import org.openstreetmap.josm.gui.MainApplication;
@@ -30 +32 @@
  */
 public class ApiPreconditionCheckerHook implements UploadHook {
+    static AbstractProperty<Boolean> PREF_LENGTH_CHECK = new BooleanProperty("upload.check-maxlength-value", true).cached();
 
     @Override
@@ -62 +65 @@
     private static boolean checkMaxNodes(Collection<OsmPrimitive> primitives, long maxNodes) {
         for (OsmPrimitive osmPrimitive : primitives) {
-            for (Map.Entry<String, String> entry: osmPrimitive.getKeys().entrySet()) {
-                String key = entry.getKey();
-                String value = entry.getValue();
-                if (!Utils.checkCodePointCount(value, Tagged.MAX_TAG_LENGTH)) {
-                    if (osmPrimitive.isDeleted()) {
-                        // if OsmPrimitive is going to be deleted we automatically shorten the value
-                        Logging.warn(
-                                tr("Automatically truncating value of tag ''{0}'' on deleted object {1}",
-                                        key,
-                                        Long.toString(osmPrimitive.getId())
-                                )
-                        );
-                        osmPrimitive.put(key, Utils.shortenString(value, Tagged.MAX_TAG_LENGTH));
-                        continue;
-                    }
-                    JOptionPane.showMessageDialog(MainApplication.getMainFrame(),
-                            tr("Length of value for tag ''{0}'' on object {1} exceeds the max. allowed length {2}. Values length is {3}.",
-                                    key, Long.toString(osmPrimitive.getId()), Tagged.MAX_TAG_LENGTH, Utils.getCodePointCount(value)
-                            ),
-                            tr("Precondition violation"),
-                            JOptionPane.ERROR_MESSAGE
-                    );
-                    MainApplication.getLayerManager().getEditDataSet().setSelected(Collections.singleton(osmPrimitive));
-                    return false;
-                }
+            if (Boolean.TRUE.equals(PREF_LENGTH_CHECK.get()) && !valueLengthCheck(osmPrimitive)) {
+                return false;
             }
 
@@ -107 +87 @@
         return true;
     }
+
+    /**
+     * Check that the tag values of a primitive are not too long.
+     * @param osmPrimitive the primitive to check
+     * @return false if any tag value of the primitive is too long, true else
+     */
+    private static boolean valueLengthCheck(OsmPrimitive osmPrimitive) {
+        for (Map.Entry<String, String> entry: osmPrimitive.getKeys().entrySet()) {
+            String key = entry.getKey();
+            String value = entry.getValue();
+            if (!Utils.checkCodePointCount(value, Tagged.MAX_TAG_LENGTH)) {
+                if (osmPrimitive.isDeleted()) {
+                    // if OsmPrimitive is going to be deleted we automatically shorten the value
+                    Logging.warn(
+                            tr("Automatically truncating value of tag ''{0}'' on deleted object {1}",
+                                    key,
+                                    Long.toString(osmPrimitive.getId())
+                            )
+                    );
+                    osmPrimitive.put(key, Utils.shortenString(value, Tagged.MAX_TAG_LENGTH));
+                    continue;
+                }
+                JOptionPane.showMessageDialog(MainApplication.getMainFrame(),
+                        tr("Length of value for tag ''{0}'' on object {1} exceeds the max. allowed length {2}. Values length is {3}.",
+                                key, Long.toString(osmPrimitive.getId()), Tagged.MAX_TAG_LENGTH, Utils.getCodePointCount(value)
+                        ),
+                        tr("Precondition violation"),
+                        JOptionPane.ERROR_MESSAGE
+                );
+                MainApplication.getLayerManager().getEditDataSet().setSelected(Collections.singleton(osmPrimitive));
+                return false;
+            }
+        }
+        return true;
+    }
 }