Changeset 19169 in josm for trunk/resources/data/validator

Timestamp:

2024-08-06T21:54:55+02:00 (17 months ago)

Author:

taylor.smock

Message:

Add/ignore documented popular tags

Add

• ​osmwiki:Tag:leaf_type=palm is a subset of ​osmwiki:Tag:leaf_type=broadleaved
• ​osmwiki:Tag:entrance=secondary
• ​osmwiki:Tag:surface=stone
• ​osmwiki:Tag:surface=woodchips
• ​osmwiki:Tag:bicycle=customers
• ​osmwiki:Tag:building=container
• ​osmwiki:Tag:parking_space=charging
• ​osmwiki:Tag:cycleway:left:lane=exclusive
• ​osmwiki:Tag:cycleway:right:lane=exclusive
• ​osmwiki:Tag:cycleway:both:lane=exclusive
• ​osmwiki:Tag:crossing=informal
• ​osmwiki:Tag:wall=concrete
• ​osmwiki:Tag:frontage_road=yes
• ​osmwiki:Tag:barrier=wicket_gate -- image drawn by taylor.smock.
• ​osmwiki:Tag:highway=emergency_bay -- image drawn by taylor.smock.
• ​osmwiki:Tag:service=slipway
• ​osmwiki:Tag:amenity=music_school -- image drawn by taylor.smock with elements from other education svg
• ​osmwiki:Tag:amenity=vehicle_inspection -- inspection was also added to shop=car_repair service types. Note that the wiki has been changed to service:vehicle instead of service, so our preset for shop=car_repair does not match wiki docs. Additionally added alternate service tagging for shop=car_repair. vehicle_inspection.svg is from ​https://wiki.openstreetmap.org/wiki/File:Vehicle_inspection-14.svg (CC0, Geozeisig).
• ​osmwiki:Tag:amenity=social_centre -- image drawn by taylor.smock. A better icon would be much appreciated.
• ​osmwiki:Tag:amenity=trolley_bay -- image drawn by taylor.smock. A better icon would be nice.
• ​osmwiki:Tag:shop=craft -- image drawn by taylor.smock.
• ​osmwiki:Tag:shop=agrarian -- image drawn by taylor.smock
• ​osmwiki:Tag:climbing=route_bottom and ​osmwiki:Tag:climbing=route_top -- image parts taken from climbing.svg
• ​osmwiki:Tag:toilets:access=customers -- added to various presets where it may be common for there to be toilets available to customers

Ignored tags:

• ​osmwiki:Tag:valley=balka -- seems to be done primarily by one or two people, highly concentrated in Russia.
• ​osmwiki:Tag:meadow=meadow_orchard -- similar to ​osmwiki:Tag:orchard=meadow_orchard, which we also ignore.
• ​osmwiki:Tag:natural=landform and ​osmwiki:Tag:landform=esker -- primarily from the canvec import

Note:
Most gate barriers were changed to either be a node or a way, as it allows for
people to micromap.

Location:

trunk/resources/data/validator

Files:

• deprecated.mapcss (modified) (1 diff)
• ignoretags.cfg (modified) (2 diffs)
• unnecessary.mapcss (modified) (1 diff)

trunk/resources/data/validator/deprecated.mapcss

@@ -2530 +2530 @@
   suggestAlternative: "{1.key}";
 }
+/* From the canvec import */
+*[natural=landform][landform=esker] {
+  throwWarning: tr("{0} should be replaced by {1}", "{1.tag}", "geological=esker";
+  group: tr("deprecated tagging");
+  suggestAlternative: "natural=ridge or geological=esker";
+}
+*[natural=landform][landform=moraine] {
+  throwWarning: tr("{0} should be replaced by {1}", "{1.tag}", "geological=moraine";
+  group: tr("deprecated tagging");
+  suggestAlternative: "geological=moraine";
+}
+*[natural=landform][landform=beach] {
+  throwWarning: tr("{0} should be replaced by {1}", "{1.tag}", "natural=beach";
+  group: tr("deprecated tagging");
+  suggestAlternative: "natural=beach";
+}
+*[natural=landform][landform=tundra_polygon] {
+  throwWarning: tr("{0} should be replaced by {1}", "{1.tag}", "natural=tundra";
+  group: tr("deprecated tagging");
+  suggestAlternative: "natural=tundra or natural=fell";
+}
 
 /* When tags are deprecated they should be added to ignoretags.cfg too. */

trunk/resources/data/validator/ignoretags.cfg

@@ -802 +802 @@
 ; orchard=meadow_orchard seems to be more of a boolean value, "also happens to be a meadow". Don't know how we want to handle it.
 K:orchard=meadow_orchard
+K:meadow=meadow_orchard
 ; boundary=religious_administration is not well documented (2023-09-21)
 K:boundary=religious_administration
@@ -815 +816 @@
 K:road_marking=solid_stop_line
 K:service=irrigation
+; canvec import
+K:natural=landform
+K:landform=esker
+K:landform=moraine
+K:landform=beach
+K:landform=tundra_polygon
+; This seems to be a region specific tag.
+K:valley=balka
 
 ; These tags should probably have better software support, but maybe they can be in the appropriate section in this file.

trunk/resources/data/validator/unnecessary.mapcss

@@ -68 +68 @@
 
 /* see ticket #7639 -- Warn when a node has the same tags as its parent way. */
-way >:sameTags node:tagged {
+/* But don't warn on barrier tags -- a common mapping method will have a barrier on the routable way and then the micromapped barrier */
+way[!barrier] >:sameTags node:tagged {
   throwWarning: tr("Nodes duplicating parent way tags");
 }