Changeset 19108 in josm for trunk/src/org/openstreetmap/josm/actions/mapmode

Timestamp:

2024-06-17T19:37:02+02:00 (16 months ago)

Author:

taylor.smock

Message:

Cleanup some new PMD warnings from PMD 7.x (followup of r19101)

File:

• trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java

@@ -390 +390 @@
         if (!map.mapView.isActiveLayerVisible())
             return;
-        if (!(Boolean) this.getValue("active"))
+        if (Boolean.FALSE.equals(this.getValue("active")))
             return;
         if (e.getButton() != MouseEvent.BUTTON1)
@@ -512 +512 @@
                     if (moveCommand == null) {
                         //make a new move command
-                        moveCommand = new MoveCommand(new ArrayList<OsmPrimitive>(movingNodeList), bestMovement);
+                        moveCommand = new MoveCommand(new ArrayList<>(movingNodeList), bestMovement);
                         UndoRedoHandler.getInstance().add(moveCommand);
                     } else {
@@ -939 +939 @@
     private EastNorth calculateBestMovementAndNewNodes(EastNorth mouseEn) {
         EastNorth bestMovement = calculateBestMovement(mouseEn);
-        EastNorth n1movedEn = initialN1en.add(bestMovement), n2movedEn;
+        EastNorth n1movedEn = initialN1en.add(bestMovement);
+        EastNorth n2movedEn;
 
         // find out the movement distance, in metres
@@ -1158 +1159 @@
         double raoffsety = symbolSize*factor*normal.getY();
 
-        double cx = center.getX(), cy = center.getY();
+        final double cx = center.getX();
+        final double cy = center.getY();
         double k = mirror ? -1 : 1;
         Point2D ra1 = new Point2D.Double(cx + raoffsetx, cy + raoffsety);